Remove the unneeded Observe method from the async instruments #3586
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RegisterCallback accept variadic Asynchronous instruments instead of a slice. Callback accept an observation result recorder to ensure instruments that are observed by a callback.
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #3586 +/- ##
=======================================
+ Coverage 79.1% 79.4% +0.2%
=======================================
Files 170 170
Lines 12654 12628 -26
=======================================
+ Hits 10020 10028 +8
+ Misses 2422 2390 -32
+ Partials 212 210 -2
|
MrAlias
changed the title
MrAlias
requested review from
jmacd,
Aneurysm9,
evantorrie,
XSAM,
dashpole and
MadVikingGod
as code owners
MrAlias
requested review from
pellared,
hanyuancheung and
dmathieu
as code owners
MrAlias
force-pushed
the
rm-observe-method
branch
from
844f9ce
to
da8e5c7
Compare
dashpole
approved these changes
Jan 23, 2023
Aneurysm9
approved these changes
Jan 25, 2023
MadVikingGod
approved these changes
Jan 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve #3590
Following #3584, the
Observemethod of the asynchronous instruments is no longer needed. It is not expected to ever be called by a user. Persisting this method only provides the opportunity to log an error and cause confusion.Additionally, the specification does not specify this method. Therefore, there is no reason to keep it.