Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ClientRequest HTTPS determination #3577

Merged
merged 5 commits into from
Jan 13, 2023

Commits on Jan 6, 2023

  1. Update ClientRequest HTTPS determination

    The ClientRequest function will only report a peer port attribute if
    that peer port differs from the standard 80 for HTTP and 443 for HTTPS.
    In determining if the request is for HTTPS use the request URL scheme.
    This is not perfect. If a user doesn't provide a scheme this will not be
    correctly detected. However, the current approach of checking if the
    `TLS` field is non-nil will always be wrong, requests made by client
    ignore this field and it is always nil. Therefore, switching to using
    the URL field is the best we can do without having already made the
    request.
    MrAlias committed Jan 6, 2023
    Configuration menu
    Copy the full SHA
    31d30b2 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    9a30cc8 View commit details
    Browse the repository at this point in the history

Commits on Jan 12, 2023

  1. Configuration menu
    Copy the full SHA
    c3fca1f View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    1858a9a View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    e09d53c View commit details
    Browse the repository at this point in the history