Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Have multi-instrument callback return an error #3576

Merged
merged 3 commits into from
Jan 8, 2023

Conversation

MrAlias
Copy link
Contributor

@MrAlias MrAlias commented Jan 6, 2023

Resolve #3573

@MrAlias MrAlias added the area:metrics Part of OpenTelemetry Metrics label Jan 6, 2023
@MrAlias MrAlias added this to the Metric v0.35.0 milestone Jan 6, 2023
@codecov
Copy link

codecov bot commented Jan 6, 2023

Codecov Report

Merging #3576 (83ff10b) into main (75a19d1) will decrease coverage by 0.0%.
The diff coverage is 0.0%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##            main   #3576     +/-   ##
=======================================
- Coverage   78.9%   78.8%   -0.1%     
=======================================
  Files        169     169             
  Lines      12435   12437      +2     
=======================================
- Hits        9812    9811      -1     
- Misses      2415    2417      +2     
- Partials     208     209      +1     
Impacted Files Coverage Δ
metric/internal/global/meter.go 95.2% <ø> (ø)
sdk/metric/pipeline.go 91.3% <0.0%> (-1.0%) ⬇️

@MrAlias MrAlias merged commit 82882df into open-telemetry:main Jan 8, 2023
@MrAlias MrAlias deleted the multi-cback-error-return branch January 8, 2023 15:53
@MrAlias MrAlias mentioned this pull request Jan 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:metrics Part of OpenTelemetry Metrics
Projects
No open projects
Status: Done
Status: Done
Development

Successfully merging this pull request may close these issues.

Return an error with the multi-callback
5 participants