-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generate semconv/v1.14.0 #3566
Merged
Merged
Generate semconv/v1.14.0 #3566
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes the template render for new upstream semantic conventions yaml.
MrAlias
requested review from
jmacd,
Aneurysm9,
evantorrie,
XSAM,
dashpole,
MadVikingGod,
pellared,
hanyuancheung and
dmathieu
as code owners
January 5, 2023 23:57
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #3566 +/- ##
=====================================
Coverage 78.8% 78.9%
=====================================
Files 169 169
Lines 12435 12435
=====================================
+ Hits 9810 9814 +4
+ Misses 2417 2413 -4
Partials 208 208
|
Aneurysm9
reviewed
Jan 6, 2023
Co-authored-by: Anthony Mirabella <a9@aneurysm9.com>
hanyuancheung
approved these changes
Jan 6, 2023
dmathieu
approved these changes
Jan 6, 2023
Aneurysm9
approved these changes
Jan 6, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please be sure to update internal/tools/go.mod
to use semconvgen v0.4.0
.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses the go.opentelemetry.io/ote/build-tools utility from this PR and applies the same render command updates as the collector in open-telemetry/opentelemetry-collector#6713
Fixes #3276