Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename metric SDK instrument kind to match API #3562

Merged
merged 2 commits into from
Jan 4, 2023
Merged

Rename metric SDK instrument kind to match API #3562

merged 2 commits into from
Jan 4, 2023

Conversation

MrAlias
Copy link
Contributor

@MrAlias MrAlias commented Jan 3, 2023

Follow up to #3530.

@MrAlias MrAlias added pkg:SDK Related to an SDK package actions Pull requests that update GitHub action code labels Jan 3, 2023
@MrAlias MrAlias added this to the Metric v0.35.0 milestone Jan 3, 2023
@MrAlias MrAlias added area:metrics Part of OpenTelemetry Metrics and removed actions Pull requests that update GitHub action code labels Jan 3, 2023
@codecov
Copy link

codecov bot commented Jan 3, 2023 •
edited
Loading

Codecov Report

Merging #3562 (e13bcef) into main (a54167d) will not change coverage.
The diff coverage is 100.0%.

Additional details and impacted files

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #3562   +/-   ##
=====================================
  Coverage   77.8%   77.8%           
=====================================
  Files        163     163           
  Lines      11850   11850           
=====================================
  Hits        9231    9231           
  Misses      2421    2421           
  Partials     198     198
Impacted Files Coverage Δ
sdk/metric/instrument.go 92.8% <ø> (ø)
sdk/metric/meter.go 92.1% <100.0%> (ø)
sdk/metric/pipeline.go 93.9% <100.0%> (ø)
sdk/metric/reader.go 100.0% <100.0%> (ø)

@MrAlias
Update CHANGELOG
e13bcef 
Fix trailing spaces and update PR number.
@MrAlias MrAlias merged commit 4607516 into open-telemetry:main Jan 4, 2023
@MrAlias MrAlias deleted the sdk-async-rename-observ branch January 4, 2023 20:47
@MrAlias MrAlias mentioned this pull request Jan 28, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmathieu dmathieu dmathieu approved these changes

@dashpole dashpole dashpole approved these changes

@hanyuancheung hanyuancheung hanyuancheung approved these changes

@jmacd jmacd Awaiting requested review from jmacd

@Aneurysm9 Aneurysm9 Awaiting requested review from Aneurysm9

@evantorrie evantorrie Awaiting requested review from evantorrie

@XSAM XSAM Awaiting requested review from XSAM XSAM is a code owner

@MadVikingGod MadVikingGod Awaiting requested review from MadVikingGod

@pellared pellared Awaiting requested review from pellared pellared is a code owner

Assignees
No one assigned
Labels
area:metrics Part of OpenTelemetry Metrics pkg:SDK Related to an SDK package
Projects
No open projects
Go: Metric SDK (Beta)
Status: Done
Milestone
Metric v0.35.0
Development

Successfully merging this pull request may close these issues.
4 participants
@MrAlias @dmathieu @dashpole @hanyuancheung