Combine precomputed values of filtered attribute sets #3549
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix open-telemetry#3439 When an attribute filter drops a distinguishing attribute during the aggregation of a precomputed sum add that value to existing, instead of just setting the value as an override (current behavior).
MrAlias
added
pkg:SDK
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #3549 +/- ##
=======================================
+ Coverage 79.0% 79.1% +0.1%
=======================================
Files 170 170
Lines 12585 12654 +69
=======================================
+ Hits 9948 10018 +70
Misses 2424 2424
+ Partials 213 212 -1
|
MrAlias
changed the title
MrAlias
requested review from
jmacd,
Aneurysm9,
evantorrie,
XSAM,
dashpole,
MadVikingGod,
pellared,
hanyuancheung and
dmathieu
as code owners
MrAlias
changed the title
dashpole
reviewed
Dec 20, 2022
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
hanyuancheung
approved these changes
Dec 21, 2022
This comment was marked as outdated.
This comment was marked as outdated.
Adds example from supplimental guide
dashpole
approved these changes
Jan 13, 2023
dashpole
reviewed
Jan 18, 2023
|
Tracking link CI failure here: #2957 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #3439
When an attribute filter drops a distinguishing attribute during the aggregation of a precomputed sum that value needs to be added to any existing one for an equivalent set1. This changes the current behavior of overriding the equivalent set's value.
Footnotes
https://github.com/open-telemetry/opentelemetry-specification/issues/2905 ↩