Global logger uses an atomic value instead of a mutex. #3545
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bogdandrutu
requested review from
jmacd,
MrAlias,
Aneurysm9,
evantorrie,
XSAM,
dashpole,
MadVikingGod,
pellared,
hanyuancheung and
dmathieu
as code owners
bogdandrutu
force-pushed
the
loggeratomic
branch
from
47c655b
to
f06e4f8
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #3545 +/- ##
=====================================
Coverage 78.0% 78.0%
=====================================
Files 164 164
Lines 11799 11795 -4
=====================================
- Hits 9212 9210 -2
+ Misses 2391 2389 -2
Partials 196 196
|
MrAlias
reviewed
Dec 16, 2022
bogdandrutu
force-pushed
the
loggeratomic
branch
from
f06e4f8
to
57b118d
Compare
Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
bogdandrutu
force-pushed
the
loggeratomic
branch
from
57b118d
to
1cc6dea
Compare
MrAlias
approved these changes
Dec 16, 2022
hanyuancheung
approved these changes
Dec 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Bogdan Drutu bogdandrutu@gmail.com