-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OTLP exporter: Let final retry error include last retryable error message #3514
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmacd
requested review from
MrAlias,
Aneurysm9,
evantorrie,
XSAM,
dashpole,
MadVikingGod,
pellared,
hanyuancheung and
dmathieu
as code owners
December 5, 2022 19:30
jmacd
changed the title
OTLP exporter: Let final retry error return the first retryable error
OTLP exporter: Let final retry error include last retryable error message
Dec 5, 2022
dashpole
approved these changes
Dec 16, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, but probably needs a changelog
MrAlias
reviewed
Dec 19, 2022
hanyuancheung
approved these changes
Dec 20, 2022
MrAlias
approved these changes
Jan 3, 2023
Thanks for the help @MadVikingGod. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #3514 +/- ##
=====================================
Coverage 77.9% 77.9%
=====================================
Files 163 163
Lines 11850 11850
=====================================
Hits 9235 9235
Misses 2417 2417
Partials 198 198
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This improves the error messages printed when an OTel-Go SDK experiences retryable errors that eventually time out. Significantly, this includes text from the final retryable error to help the user understand the why the timeout has been reached.
I briefly updates the OTel collector example main() to avoid blocking in dial, to demonstrate the problem. After this change:
Before this change:
Part of #3513.