feat(exporter): Jaeger and Zipkin exporter use logr as the logging interface
#3500
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…gr` as the logging interface, and add the WithLogr option
aniaan
requested review from
jmacd,
MrAlias,
Aneurysm9,
evantorrie,
XSAM,
dashpole,
MadVikingGod,
pellared,
hanyuancheung and
dmathieu
as code owners
|
|
Aneurysm9
reviewed
Nov 30, 2022
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #3500 +/- ##
=======================================
- Coverage 77.9% 77.9% -0.1%
=======================================
Files 164 164
Lines 11699 11703 +4
=======================================
+ Hits 9119 9121 +2
- Misses 2385 2387 +2
Partials 195 195
|
MrAlias
reviewed
Dec 2, 2022
MrAlias
approved these changes
Dec 2, 2022
dmathieu
approved these changes
Dec 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close: #3497
Please help to see if this change is appropriate, cc @MadVikingGod