Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add semconv/v1.10.0 #2842

Merged
merged 4 commits into from
Apr 22, 2022
Merged

Add semconv/v1.10.0 #2842

merged 4 commits into from
Apr 22, 2022

Conversation

MrAlias
Copy link
Contributor

@MrAlias MrAlias commented Apr 21, 2022

Resolve #2762

@MrAlias MrAlias added this to the Release v1.7.0 milestone Apr 21, 2022
@codecov
Copy link

codecov bot commented Apr 21, 2022 •
edited
Loading

Codecov Report

Merging #2842 (7d1f655) into main (f0a727e) will decrease coverage by 0.0%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##            main   #2842     +/-   ##
=======================================
- Coverage   75.7%   75.7%   -0.1%     
=======================================
  Files        178     178             
  Lines      11707   11707             
=======================================
- Hits        8868    8864      -4     
- Misses      2614    2618      +4     
  Partials     225     225
Impacted Files Coverage Δ
bridge/opentracing/internal/mock.go 67.0% <ø> (ø)
exporters/jaeger/jaeger.go 91.1% <ø> (ø)
exporters/zipkin/model.go 94.6% <ø> (ø)
sdk/resource/builtin.go 90.3% <ø> (ø)
sdk/resource/container.go 92.3% <ø> (ø)
sdk/resource/env.go 93.0% <ø> (ø)
sdk/resource/os.go 93.3% <ø> (ø)
sdk/resource/process.go 98.4% <ø> (ø)
sdk/trace/span.go 87.8% <ø> (ø)
sdk/trace/batch_span_processor.go 80.2% <0.0%> (-1.9%) ⬇️

dashpole
dashpole approved these changes Apr 21, 2022
View reviewed changes
Copy link
Contributor

@dashpole dashpole left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't look in detail at the generated attributes, but other changes look good

evantorrie
evantorrie approved these changes Apr 22, 2022
View reviewed changes
Copy link
Contributor

@evantorrie evantorrie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MrAlias MrAlias merged commit c05c3e2 into open-telemetry:main Apr 22, 2022
@MrAlias MrAlias deleted the semconv-v1.10.0 branch April 22, 2022 14:41
@MrAlias MrAlias mentioned this pull request Apr 28, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dashpole dashpole dashpole approved these changes

@evantorrie evantorrie evantorrie approved these changes

@jmacd jmacd Awaiting requested review from jmacd

@Aneurysm9 Aneurysm9 Awaiting requested review from Aneurysm9

@XSAM XSAM Awaiting requested review from XSAM XSAM is a code owner

@paivagustavo paivagustavo Awaiting requested review from paivagustavo

@MadVikingGod MadVikingGod Awaiting requested review from MadVikingGod

@pellared pellared Awaiting requested review from pellared pellared is a code owner

@hanyuancheung hanyuancheung Awaiting requested review from hanyuancheung

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Release v1.7.0
Development

Successfully merging this pull request may close these issues.

Generate v1.10.0 semconv
3 participants
@MrAlias @dashpole @evantorrie