Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add semconv/v1.9.0 package #2792

Merged
merged 2 commits into from
Apr 18, 2022
Merged

Conversation

bradtopol
Copy link
Contributor

Closes: #2756

Signed-off-by: Brad Topol btopol@us.ibm.com

@codecov
Copy link

codecov bot commented Apr 16, 2022

Codecov Report

Merging #2792 (8dce90a) into main (a8ea3db) will increase coverage by 0.0%.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #2792   +/-   ##
=====================================
  Coverage   75.7%   75.7%           
=====================================
  Files        178     178           
  Lines      11707   11707           
=====================================
+ Hits        8866    8868    +2     
+ Misses      2616    2614    -2     
  Partials     225     225           
Impacted Files Coverage Δ
bridge/opentracing/internal/mock.go 67.0% <ø> (ø)
exporters/jaeger/jaeger.go 91.1% <ø> (+0.8%) ⬆️
exporters/zipkin/model.go 94.6% <ø> (ø)
sdk/resource/builtin.go 90.3% <ø> (ø)
sdk/resource/container.go 92.3% <ø> (ø)
sdk/resource/env.go 93.0% <ø> (ø)
sdk/resource/os.go 93.3% <ø> (ø)
sdk/resource/process.go 98.4% <ø> (ø)
sdk/trace/span.go 87.8% <ø> (ø)

@Aneurysm9 Aneurysm9 added this to the Release v1.7.0 milestone Apr 16, 2022
Copy link
Contributor

@MrAlias MrAlias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Please rebase with main.

Closes: open-telemetry#2756

Signed-off-by: Brad Topol <btopol@us.ibm.com>
Signed-off-by: Brad Topol <btopol@us.ibm.com>
@bradtopol
Copy link
Contributor Author

Rebase complete. Thanks for the quick reviews @MrAlias @dashpole!!!

@MrAlias MrAlias merged commit 8574d43 into open-telemetry:main Apr 18, 2022
@MrAlias MrAlias mentioned this pull request Apr 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Generate v1.9.0 semconv
4 participants