-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace use of old term label with attribute #2790
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The specification has unified on the term attribute to describe key-value pairs. There exist still many hold-overs of the use of the term label. This updates those uses or deprecates exported types and functions in favor of renamed forms.
Codecov Report
@@ Coverage Diff @@
## main #2790 +/- ##
=====================================
Coverage 75.7% 75.7%
=====================================
Files 178 178
Lines 11703 11707 +4
=====================================
+ Hits 8864 8868 +4
Misses 2614 2614
Partials 225 225
|
MrAlias
requested review from
jmacd,
Aneurysm9,
evantorrie,
XSAM,
dashpole,
paivagustavo,
MadVikingGod,
pellared and
hanyuancheung
as code owners
April 15, 2022 17:10
Aneurysm9
approved these changes
Apr 15, 2022
XSAM
approved these changes
Apr 18, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🥇
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The specification has unified on the term attribute to describe key-value pairs. There exist still many hold-overs of the use of the term label. This updates those uses or deprecates exported types and functions in favor of renamed forms.
Changed
WithLabelEncoder
option from thego.opentelemetry.io/otel/exporters/stdout/stdoutmetric
package is renamed toWithAttributeEncoder
.Batch.Labels
field from thego.opentelemetry.io/otel/sdk/metric/metrictest
package is renamed toBatch.Attributes
.LabelFilterSelector
interface fromgo.opentelemetry.io/otel/sdk/metric/processor/reducer
is renamed toAttributeFilterSelector
. The method included in the renamed interface also changed fromLabelFilterFor
toAttributeFilterFor
.Metadata.Labels
method from thego.opentelemetry.io/otel/sdk/metric/export
package is renamed toMetadata.Attributes
. Consequentially, theRecord
type from the same package also has had the embedded method renamed.Deprecated
Iterator.Label
method in thego.opentelemetry.io/otel/attribute
package is deprecated. Use the equivalentIterator.Attribute
method instead.Iterator.IndexedLabel
method in thego.opentelemetry.io/otel/attribute
package is deprecated. Use the equivalentIterator.IndexedAttribute
method instead.MergeIterator.Label
method in thego.opentelemetry.io/otel/attribute
package is deprecated. Use the equivalentMergeIterator.Attribute
method instead.