Rename all test funcs that mix camel and snake #2788
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unify on Go standard camel case naming.
MrAlias
requested review from
jmacd,
Aneurysm9,
evantorrie,
XSAM,
dashpole,
paivagustavo,
MadVikingGod,
pellared and
hanyuancheung
as code owners
bradtopol
reviewed
Apr 14, 2022
|
Great job! The snakes have left the building :-). LGTM |
Aneurysm9
approved these changes
Apr 14, 2022
dashpole
approved these changes
Apr 14, 2022
|
I would caution doing too much of this. For tests it is probably ok, but for examples the current format is the format prescribed to get them to appear in the correct place in the documentation. |
Codecov Report
@@ Coverage Diff @@
## main #2788 +/- ##
=====================================
Coverage 75.7% 75.7%
=====================================
Files 178 178
Lines 11703 11703
=====================================
+ Hits 8862 8864 +2
+ Misses 2616 2614 -2
Partials 225 225
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unify on Go standard camel case naming.