-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow non-comparable global types #2773
Conversation
The global MeterProvider, TracerProvider, and TextMapPropagator should not panic when they are set to a non-comparable implementation of each.
Codecov Report
@@ Coverage Diff @@
## main #2773 +/- ##
=======================================
- Coverage 76.8% 76.8% -0.1%
=======================================
Files 181 181
Lines 12188 12193 +5
=======================================
+ Hits 9362 9365 +3
- Misses 2601 2603 +2
Partials 225 225
|
This is fine by me. Just want to reference that the comparison was moved out of the |
That still seems like the appropriate behavior for the reasons listed in the linked comment, we don't want to fail the delegation forever if the user sets the delegate to itself. It was correct for that change to have been made. Iterative improvement is the name of the game. |
Merging prior to the 1 working day project policy. The goal is to get a patch release out ASAP with this change. |
The global
MeterProvider
,TracerProvider
, andTextMapPropagator
should not panic when they are set to a non-comparable implementation of each.Fix #2772