Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade go.opentelemetry.io/proto/otlp v0.12.0 -> v0.12.1 #2728

Merged
merged 2 commits into from
Mar 27, 2022
Merged

Upgrade go.opentelemetry.io/proto/otlp v0.12.0 -> v0.12.1 #2728

merged 2 commits into from
Mar 27, 2022

Conversation

MrAlias
Copy link
Contributor

@MrAlias MrAlias commented Mar 25, 2022

Fix #2724

@MrAlias MrAlias added this to the Release v1.7.0 milestone Mar 25, 2022
@codecov
Copy link

codecov bot commented Mar 25, 2022

Codecov Report

Merging #2728 (6a5ea2a) into main (0024f7c) will increase coverage by 0.0%.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #2728   +/-   ##
=====================================
  Coverage   76.7%   76.7%           
=====================================
  Files        181     181           
  Lines      12175   12175           
=====================================
+ Hits        9345    9347    +2     
+ Misses      2605    2603    -2     
  Partials     225     225
Impacted Files Coverage Δ
exporters/jaeger/jaeger.go 90.3% <0.0%> (-0.9%) ⬇️
sdk/trace/batch_span_processor.go 82.1% <0.0%> (+1.8%) ⬆️

XSAM
XSAM approved these changes Mar 26, 2022
View reviewed changes
Copy link
Member

@XSAM XSAM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@MrAlias MrAlias merged commit 7a1ebf7 into open-telemetry:main Mar 27, 2022
@MrAlias MrAlias deleted the proto-upgrade branch March 27, 2022 00:30
@MrAlias MrAlias mentioned this pull request Mar 28, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@XSAM XSAM XSAM approved these changes

@hanyuancheung hanyuancheung hanyuancheung approved these changes

@jmacd jmacd Awaiting requested review from jmacd

@Aneurysm9 Aneurysm9 Awaiting requested review from Aneurysm9

@evantorrie evantorrie Awaiting requested review from evantorrie

@dashpole dashpole Awaiting requested review from dashpole dashpole is a code owner

@paivagustavo paivagustavo Awaiting requested review from paivagustavo

@MadVikingGod MadVikingGod Awaiting requested review from MadVikingGod

@pellared pellared Awaiting requested review from pellared pellared is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Release v1.6.1
Development

Successfully merging this pull request may close these issues.

Upgrade go.opentelemetry.io/proto
3 participants
@MrAlias @XSAM @hanyuancheung