Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Apply fix from #2674 to all applicable lines #2719

Merged
merged 3 commits into from
Mar 24, 2022
Merged

Apply fix from #2674 to all applicable lines #2719

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
16ec5d2
Apply fix from #2674 to all applicable lines
MrAlias Mar 23, 2022
7ae3cfd
Merge branch 'main' into 2674-followup
MrAlias Mar 23, 2022
b47174b
Merge branch 'main' into 2674-followup
MrAlias Mar 23, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions exporters/otlp/otlpmetric/internal/otlpconfig/options_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -256,6 +256,7 @@ func TestConfigs(t *testing.T) {
if grpcOption {
assert.NotNil(t, c.Metrics.GRPCCredentials)
} else {
// nolint:staticcheck // ignoring tlsCert.RootCAs.Subjects is deprecated ERR because cert does not come from SystemCertPool.
assert.Equal(t, 1, len(c.Metrics.TLSCfg.RootCAs.Subjects()))
}
},
Expand Down