Unify OTLP path parsing/default Logic #2639
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hanyuancheung
requested review from
jmacd,
MrAlias,
Aneurysm9,
evantorrie,
XSAM,
dashpole,
paivagustavo,
MadVikingGod and
pellared
as code owners
Codecov Report
@@ Coverage Diff @@
## main #2639 +/- ##
=====================================
Coverage 76.0% 76.0%
=====================================
Files 173 174 +1
Lines 12293 12286 -7
=====================================
- Hits 9344 9341 -3
Misses 2702 2702
+ Partials 247 243 -4
|
MrAlias
reviewed
Feb 24, 2022
Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
MrAlias
approved these changes
Feb 25, 2022
hanyuancheung
force-pushed
the
unify-otlp-path-logic
branch
from
e186629
to
b2566ce
Compare
|
PTLA. |
XSAM
reviewed
Mar 2, 2022
Co-authored-by: Sam Xie <sam@samxie.me>
Co-authored-by: Sam Xie <sam@samxie.me>
Co-authored-by: Sam Xie <sam@samxie.me>
Co-authored-by: Sam Xie <sam@samxie.me>
Co-authored-by: Sam Xie <sam@samxie.me>
Co-authored-by: Sam Xie <sam@samxie.me>
XSAM
approved these changes
Mar 2, 2022
hanyuancheung
added a commit
to hanyuancheung/opentelemetry-go
that referenced
this pull request
Mar 5, 2022
* unify otlp path parsing/default logic * add changelog * add license and unit test * remove else branch * increase unitt test coverage * add vanity import * Update exporters/otlp/internal/config.go Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com> * Update exporters/otlp/internal/config.go Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com> * Update exporters/otlp/internal/config.go Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com> * Update CHANGELOG.md Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com> * Update exporters/otlp/internal/config_test.go Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com> * Update exporters/otlp/internal/config_test.go Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com> * format the config_test.go * Update exporters/otlp/internal/config_test.go Co-authored-by: Sam Xie <sam@samxie.me> * Update exporters/otlp/internal/config_test.go Co-authored-by: Sam Xie <sam@samxie.me> * Update exporters/otlp/internal/config_test.go Co-authored-by: Sam Xie <sam@samxie.me> * Update exporters/otlp/internal/config_test.go Co-authored-by: Sam Xie <sam@samxie.me> * Update exporters/otlp/internal/config.go Co-authored-by: Sam Xie <sam@samxie.me> * Update exporters/otlp/internal/config.go Co-authored-by: Sam Xie <sam@samxie.me> * change URLPath to urlPath Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com> Co-authored-by: Sam Xie <sam@samxie.me>
Merged
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #2634 and #2625 (comment)