Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix TestBackoffRetry in otlp/internal/retry package #2562

Merged
merged 7 commits into from
Jan 31, 2022
Merged

Fix TestBackoffRetry in otlp/internal/retry package #2562

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
c6783b6
Fix TestBackoffRetry in otlp retry pkg
MrAlias Jan 28, 2022
17ca1a5
Merge branch 'main' into fix-retry-test
MrAlias Jan 28, 2022
90ee75d
Fix delta value
MrAlias Jan 28, 2022
4d75df5
Merge branch 'fix-retry-test' of github.com:MrAlias/opentelemetry-go …
MrAlias Jan 28, 2022
0d8f110
Fix delta
MrAlias Jan 28, 2022
c5c13d4
Merge branch 'main' into fix-retry-test
MadVikingGod Jan 31, 2022
d98c50c
Merge branch 'main' into fix-retry-test
MrAlias Jan 31, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions exporters/otlp/internal/retry/retry_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,9 +17,11 @@ package retry
import (
"context"
"errors"
"math"
"testing"
"time"

"github.com/cenkalti/backoff/v4"
"github.com/stretchr/testify/assert"
)

Expand Down Expand Up @@ -131,15 +133,16 @@ func TestBackoffRetry(t *testing.T) {
origWait := waitFunc
var done bool
waitFunc = func(_ context.Context, d time.Duration) error {
assert.Equal(t, delay, d, "retry not backoffed")
delta := math.Ceil(float64(delay)*backoff.DefaultRandomizationFactor) - float64(delay)
assert.InDelta(t, delay, d, delta, "retry not backoffed")
// Try twice to ensure call is attempted again after delay.
if done {
return assert.AnError
}
done = true
return nil
}
defer func() { waitFunc = origWait }()
t.Cleanup(func() { waitFunc = origWait })

ctx := context.Background()
assert.ErrorIs(t, reqFunc(ctx, func(context.Context) error {
Expand Down