-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix per-signal endpoint parsing in OTLP exporters #2433
Conversation
0002114
to
36ca50e
Compare
Codecov Report
@@ Coverage Diff @@
## main #2433 +/- ##
=====================================
Coverage 76.0% 76.0%
=====================================
Files 173 173
Lines 11938 12008 +70
=====================================
+ Hits 9074 9134 +60
- Misses 2621 2629 +8
- Partials 243 245 +2
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it could be good to update the docs e.g. here: https://github.com/open-telemetry/opentelemetry-go/tree/main/exporters/otlp/otlptrace
Can be done in a separate PR.
The linked documentation does not contain any mention of the behavior that is being fixed here as far as I can see. I'm not sure what needs to be updated there. |
I find it very inconvenient that there is no information that |
Ah, I see. Let me look into adding something. |
Resolve #2338