Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: adds vanity import check. #2255

Merged
merged 12 commits into from
Sep 28, 2021

Conversation

jcchavezs
Copy link
Contributor

@jcchavezs jcchavezs commented Sep 25, 2021

This PR adds check on CI to verify vanity imports are rightfully added.

@pellared
Copy link
Member

Makefile Outdated Show resolved Hide resolved
Copy link
Contributor

@jmacd jmacd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
@jcchavezs
Copy link
Contributor Author

@pellared that was actually an idea but first I wanted to see this in action here.

@jcchavezs
Copy link
Contributor Author

This is failing now on purpose. I wanted it to fail to test the setup.

@jcchavezs
Copy link
Contributor Author

Do we need to update changelog?

@Aneurysm9 Aneurysm9 added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Sep 28, 2021
@codecov
Copy link

codecov bot commented Sep 28, 2021

Codecov Report

Merging #2255 (2623175) into main (28f335e) will increase coverage by 0.0%.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #2255   +/-   ##
=====================================
  Coverage   72.4%   72.5%           
=====================================
  Files        168     168           
  Lines      11872   11872           
=====================================
+ Hits        8606    8609    +3     
+ Misses      3031    3029    -2     
+ Partials     235     234    -1     
Impacted Files Coverage Δ
attribute/type_string.go 40.0% <ø> (ø)
baggage/baggage.go 98.2% <ø> (ø)
bridge/opencensus/aggregation.go 100.0% <ø> (ø)
bridge/opencensus/bridge.go 0.0% <ø> (ø)
bridge/opencensus/exporter.go 100.0% <ø> (ø)
exporters/otlp/otlpmetric/exporter.go 60.6% <ø> (ø)
exporters/otlp/otlpmetric/options.go 100.0% <ø> (ø)
...xporters/otlp/otlpmetric/otlpmetricgrpc/options.go 83.3% <ø> (ø)
exporters/otlp/otlpmetric/otlpmetrichttp/client.go 93.4% <ø> (ø)
...xporters/otlp/otlpmetric/otlpmetrichttp/options.go 100.0% <ø> (ø)
... and 8 more

@Aneurysm9 Aneurysm9 merged commit 099df58 into open-telemetry:main Sep 28, 2021
@jcchavezs jcchavezs deleted the vanity_import_check branch October 6, 2021 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants