adding NewNoopMeterProvider to follow trace api #2237
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codeboten
requested review from
Aneurysm9,
dashpole,
evantorrie,
jmacd,
MadVikingGod,
MrAlias,
paivagustavo,
pellared and
XSAM
as code owners
Codecov Report
@@ Coverage Diff @@
## main #2237 +/- ##
=====================================
Coverage 72.4% 72.4%
=====================================
Files 168 168
Lines 11764 11766 +2
=====================================
+ Hits 8526 8530 +4
+ Misses 3003 3001 -2
Partials 235 235
|
Aneurysm9
reviewed
Sep 10, 2021
codeboten
force-pushed
the
codeboten/add-newnoopmeterprovider-method
branch
from
567383c
to
fc3f099
Compare
Co-authored-by: Anthony Mirabella <a9@aneurysm9.com>
jmacd
approved these changes
Sep 10, 2021
dashpole
approved these changes
Sep 10, 2021
XSAM
approved these changes
Sep 11, 2021
MrAlias
approved these changes
Sep 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The trace API provides the
NewNoopTracerProvidermethod to return a noopTracerProvider. This PR adds the methodNewNoopMeterProviderin the metric API. This is also makingNoopTracerProviderprivate.