Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update otel example guide #2210

Merged
merged 1 commit into from
Aug 30, 2021
Merged

Update otel example guide #2210

merged 1 commit into from
Aug 30, 2021

Conversation

tomasmota
Copy link
Contributor

Fix example documentation in order to reflect changes made in PR #1006

Jaeger exporter in collector config has been renamed to just "jaeger" instead of "jaeger_grpc"

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Aug 30, 2021

CLA Signed

The committers are authorized under a signed CLA.

@codecov
Copy link

codecov bot commented Aug 30, 2021

Codecov Report

Merging #2210 (c30d6b7) into main (3b05ba0) will decrease coverage by 0.0%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##            main   #2210     +/-   ##
=======================================
- Coverage   72.9%   72.9%   -0.1%     
=======================================
  Files        176     176             
  Lines      12161   12161             
=======================================
- Hits        8870    8867      -3     
- Misses      3053    3055      +2     
- Partials     238     239      +1     
Impacted Files Coverage Δ
...s/otlp/otlptrace/internal/connection/connection.go 14.8% <0.0%> (-1.6%) ⬇️

@tomasmota
Copy link
Contributor Author

Please label as 'skip changelog'

@MrAlias MrAlias added Skip Changelog PRs that do not require a CHANGELOG.md entry bug Something isn't working pkg:example Related to an example labels Aug 30, 2021
@MrAlias MrAlias merged commit abf6afe into open-telemetry:main Aug 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working pkg:example Related to an example Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants