Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify the attribute package documentation and order/grouping #2168

Merged
merged 7 commits into from
Aug 11, 2021
Merged

Clarify the attribute package documentation and order/grouping #2168

merged 7 commits into from
Aug 11, 2021

Conversation

MrAlias
Copy link
Contributor

@MrAlias MrAlias commented Aug 6, 2021

Remove the outdated package name from the documentation that recommends using the convenience functions. Move the Int method closer to the Int64 method.

Part of #2162

@MrAlias MrAlias added documentation Provides helpful information Skip Changelog PRs that do not require a CHANGELOG.md entry labels Aug 6, 2021
@MrAlias MrAlias changed the title Clarify the attribute package Key method documentation and order/grouping Clarify the attribute package documentation and order/grouping Aug 6, 2021
@MrAlias MrAlias marked this pull request as draft August 6, 2021 17:44
@codecov
Copy link

codecov bot commented Aug 6, 2021 •
edited
Loading

Codecov Report

Merging #2168 (e91e754) into main (5d25c4d) will not change coverage.
The diff coverage is 100.0%.

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #2168   +/-   ##
=====================================
  Coverage   72.3%   72.3%           
=====================================
  Files        176     176           
  Lines      12093   12093           
=====================================
  Hits        8755    8755           
  Misses      3100    3100           
  Partials     238     238
Impacted Files Coverage Δ
attribute/key.go 100.0% <100.0%> (ø)
attribute/kv.go 90.0% <100.0%> (ø)
attribute/value.go 93.1% <100.0%> (ø)

@MrAlias MrAlias marked this pull request as ready for review August 6, 2021 17:50
pellared
pellared approved these changes Aug 11, 2021
View reviewed changes
Copy link
Member

@pellared pellared left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a few nit comments

attribute/key.go Outdated Show resolved Hide resolved
attribute/key.go Outdated Show resolved Hide resolved
attribute/kv.go Outdated Show resolved Hide resolved
attribute/key.go Outdated Show resolved Hide resolved
attribute/key.go Outdated Show resolved Hide resolved
attribute/key.go Outdated Show resolved Hide resolved
attribute/key.go Outdated Show resolved Hide resolved
attribute/key.go Outdated Show resolved Hide resolved
@MrAlias MrAlias merged commit a882ee3 into open-telemetry:main Aug 11, 2021
@MrAlias MrAlias deleted the attr-key-doc branch August 11, 2021 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cbandy cbandy cbandy approved these changes

@jmacd jmacd jmacd approved these changes

@pellared pellared pellared approved these changes

@Aneurysm9 Aneurysm9 Awaiting requested review from Aneurysm9

@dashpole dashpole Awaiting requested review from dashpole dashpole is a code owner

@evantorrie evantorrie Awaiting requested review from evantorrie

@MadVikingGod MadVikingGod Awaiting requested review from MadVikingGod

@paivagustavo paivagustavo Awaiting requested review from paivagustavo

@XSAM XSAM Awaiting requested review from XSAM XSAM is a code owner

Assignees
No one assigned
Labels
documentation Provides helpful information Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@MrAlias @cbandy @jmacd @pellared