Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate oteltest.Harness for removal #2123

Merged
merged 6 commits into from
Jul 26, 2021

Conversation

MrAlias
Copy link
Contributor

@MrAlias MrAlias commented Jul 22, 2021

This harness is intended to validate the specified functionality of an SDK. It only partially does this as it has not been maintained as the specification evolved. Having a stale testing structure is acceptable in helping this project prevent regressions until we have time to update or replace it, but exporting this for users to rely on is not okay.

This deprecates the harness with the intent to remove it in the next release as it looks like this is the only published project, outside of copies, that uses it. To achieve the prevention of regressions mentioned above, this makes an internal copy of the harness that is expected to last when the original is removed.

Part of #2121

@codecov
Copy link

codecov bot commented Jul 22, 2021

Codecov Report

Merging #2123 (4007fe6) into main (7a624ac) will decrease coverage by 2.0%.
The diff coverage is 0.0%.

Impacted file tree graph

@@           Coverage Diff           @@
##            main   #2123     +/-   ##
=======================================
- Coverage   73.6%   71.5%   -2.1%     
=======================================
  Files        168     169      +1     
  Lines       8234    8235      +1     
=======================================
- Hits        6062    5893    -169     
- Misses      1933    2102    +169     
- Partials     239     240      +1     
Impacted Files Coverage Δ
internal/internaltest/harness.go 0.0% <0.0%> (ø)
oteltest/harness.go 0.0% <0.0%> (-84.7%) ⬇️
...s/otlp/otlptrace/internal/connection/connection.go 13.7% <0.0%> (-2.5%) ⬇️

@MrAlias MrAlias marked this pull request as ready for review July 22, 2021 18:51
oteltest/harness.go Outdated Show resolved Hide resolved
remove `oteltest` import.
@Aneurysm9 Aneurysm9 merged commit bbe6ca4 into open-telemetry:main Jul 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants