-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support a single Resource per MeterProvider in the SDK #2120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmacd
requested review from
Aneurysm9,
dashpole,
evantorrie,
MadVikingGod,
MrAlias,
paivagustavo,
pellared and
XSAM
as code owners
July 22, 2021 06:02
Codecov Report
@@ Coverage Diff @@
## main #2120 +/- ##
=======================================
- Coverage 72.8% 72.7% -0.1%
=======================================
Files 177 177
Lines 12148 12126 -22
=======================================
- Hits 8848 8825 -23
+ Misses 3063 3062 -1
- Partials 237 239 +2
|
jmacd
commented
Jul 22, 2021
Aneurysm9
reviewed
Jul 23, 2021
MrAlias
approved these changes
Aug 6, 2021
…y-go into jmacd/remove_resource
pellared
approved these changes
Aug 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The specification for Resource SDK says that there can be just one
Resource
used by an individual MeterProvider (and TraceProvider). This implies we can simplify the export path to use a single Resource perExport()
, which simplifies the OTLP Exporter substantially.What changes:
export.Record
no longer contains a*resource.Resource
Export()
methods now receive a single*resource.Resource
sdk/metric/controller/basic
now passes the*resource.Resource
toExport()
directlysdk/metric/sdk.go
(theAccumulator
) no longer touches a*resource.Resource
exporters/otlp/otlpmetric
code path no longer groups by*resource.Resource
Part of #2086.
Part of #2119.