Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the propagation/propagationtest package #2113

Closed
wants to merge 2 commits into from

Conversation

MrAlias
Copy link
Contributor

@MrAlias MrAlias commented Jul 21, 2021

Move the propagation related types from the oteltest package into the new propagation/propagationtest package. This encapsulates the testing types and allows us to remove the dependency on the oteltest package from the otel package (related to #2077).

@codecov
Copy link

codecov bot commented Jul 21, 2021

Codecov Report

Merging #2113 (71cd299) into main (4935949) will increase coverage by 0.3%.
The diff coverage is 75.6%.

Impacted file tree graph

@@           Coverage Diff           @@
##            main   #2113     +/-   ##
=======================================
+ Coverage   72.8%   73.1%   +0.3%     
=======================================
  Files        166     167      +1     
  Lines       8188    8240     +52     
=======================================
+ Hits        5966    6030     +64     
+ Misses      1992    1977     -15     
- Partials     230     233      +3     
Impacted Files Coverage Δ
oteltest/text_map_propagator.go 76.2% <ø> (ø)
propagation/propagationtest/text_map_carrier.go 73.0% <73.0%> (ø)
propagation/propagationtest/text_map_propagator.go 80.0% <80.0%> (ø)
sdk/export/metric/metrictest/test.go
sdk/metric/processor/processortest/test.go 89.8% <0.0%> (+<0.1%) ⬆️
exporters/jaeger/jaeger.go 94.2% <0.0%> (+1.1%) ⬆️
exporters/stdout/stdoutmetric/metric.go 80.0% <0.0%> (+1.4%) ⬆️
sdk/metric/aggregator/aggregatortest/test.go 86.8% <0.0%> (+2.0%) ⬆️

@MrAlias
Copy link
Contributor Author

MrAlias commented Jul 21, 2021

It looks like the internal/global package is the only place that actually uses this code. It seems like it would make more sense to just move it into the internal package.

@MrAlias MrAlias closed this Jul 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant