-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add HTTP metrics exporter for OTLP #2022
Add HTTP metrics exporter for OTLP #2022
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2022 +/- ##
=======================================
+ Coverage 72.4% 72.7% +0.2%
=======================================
Files 161 164 +3
Lines 7943 8079 +136
=======================================
+ Hits 5756 5876 +120
- Misses 1961 1974 +13
- Partials 226 229 +3
|
b4e0e15
to
a5689ab
Compare
f194bfc
to
62e36e6
Compare
Hi, all checks have passed, could anyone convenient help to review this PR? Thx. |
Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for taking this @zhyChesterCheung. Some small comments but overall looks good!
The problems mentioned above all have been fixed ~ @MrAlias @paivagustavo |
@zhyChesterCheung can you merge in |
All conflicts have been resolved, great to see the checks all passed and this PR is ready to merge. Could you merge it please? @MrAlias @paivagustavo |
Resolved: #2014 this is part of the #1827 todo list: