-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bugfix jaeger exporter test panic #1973
Bugfix jaeger exporter test panic #1973
Conversation
Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
Hi, I'm a first-time contributor, could anybody help to approve running these workflows, great thx~ |
When running the ci / test-coverage, something wrong happened with: |
Codecov Report
@@ Coverage Diff @@
## main #1973 +/- ##
=======================================
+ Coverage 76.5% 77.1% +0.6%
=======================================
Files 160 161 +1
Lines 8495 8554 +59
=======================================
+ Hits 6503 6602 +99
+ Misses 1733 1696 -37
+ Partials 259 256 -3
|
It seems like the codecov endpoint is having issues today. I have seen quite a lot of this error in other PRs. Rerunning can resolve the issue as it looks like it is an instability on the receiving side, not our sending side. |
This PR adds logic to determine if the channel is closed to fix jaeger exporter test panic with close of closed channel.
Resolves #1870