Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Redefine ExportSpans of SpanExporter with ReadOnlySpan #1873

Merged
merged 18 commits into from
May 4, 2021
Merged

Redefine ExportSpans of SpanExporter with ReadOnlySpan #1873

merged 18 commits into from
May 4, 2021

Commits on Apr 30, 2021

  1. Remove TODO from ReadOnlySpan interface

    @MrAlias
    MrAlias committed Apr 30, 2021
    Configuration menu
    Copy the full SHA
    8bbd971 View commit details
    Browse the repository at this point in the history

  2. Remove the Tracer method from the ReadOnlySpan 

    This is not required by the specification nor the use of this interface.
    @MrAlias
    MrAlias committed Apr 30, 2021
    Configuration menu
    Copy the full SHA
    268d78a View commit details
    Browse the repository at this point in the history

  3. Add Status type to SDK 

    Use this type to encapsulate the Span status similar to the Event type
encapsulating a Span event
    @MrAlias
    MrAlias committed Apr 30, 2021
    Configuration menu
    Copy the full SHA
    72fedf7 View commit details
    Browse the repository at this point in the history

  4. Remove IsRecording from the ReadOnlySpan interface 

    A read-only span value does not need to know if updates to it will be
recorded. It by definition cannot be updated so no point in
communicating if an update would be recorded.
    @MrAlias
    MrAlias committed Apr 30, 2021
    Configuration menu
    Copy the full SHA
    88a4533 View commit details
    Browse the repository at this point in the history

  5. Document the ReadOnlySpan interface

    @MrAlias
    MrAlias committed Apr 30, 2021
    Configuration menu
    Copy the full SHA
    d1b8ca3 View commit details
    Browse the repository at this point in the history

  6. Rename messageEvent* to just event*

    @MrAlias
    MrAlias committed Apr 30, 2021
    Configuration menu
    Copy the full SHA
    86ae1ff View commit details
    Browse the repository at this point in the history

  7. Move the SpanSnapshot into its own file

    @MrAlias
    MrAlias committed Apr 30, 2021
    Configuration menu
    Copy the full SHA
    b88adf5 View commit details
    Browse the repository at this point in the history

  8. Update ReadOnlySpan interface with meta info methods 

    Add the DroppedAttributes, DroppedLinks, DroppedEvents, and
ChildSpanCount methods to the interface to return additional information
about the span not specified by the specification, but that we are
already providing.
    @MrAlias
    MrAlias committed Apr 30, 2021
    Configuration menu
    Copy the full SHA
    49edd27 View commit details
    Browse the repository at this point in the history

Commits on May 2, 2021

  1. Add SpanStub to the sdk/trace/tracetest pkg

    @MrAlias
    MrAlias committed May 2, 2021
    Configuration menu
    Copy the full SHA
    45a0e20 View commit details
    Browse the repository at this point in the history

  2. Redefine ExportSpans of SpanExporter with ReadOnlySpan

    @MrAlias
    MrAlias committed May 2, 2021
    Configuration menu
    Copy the full SHA
    32110d2 View commit details
    Browse the repository at this point in the history

  3. Rename SpanSnapshot to snapshot and purge docs

    @MrAlias
    MrAlias committed May 2, 2021
    Configuration menu
    Copy the full SHA
    4c92b72 View commit details
    Browse the repository at this point in the history

  4. Remove Snapshot method from snapshot type 

    This method is a hold-over from previous version of the ReadOnlySpan
interface is not needed.
    @MrAlias
    MrAlias committed May 2, 2021
    Configuration menu
    Copy the full SHA
    7eb21f1 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'main' into ro-span-export

    @MrAlias
    MrAlias authored May 2, 2021
    Configuration menu
    Copy the full SHA
    f985b87 View commit details
    Browse the repository at this point in the history

Commits on May 3, 2021

  1. Merge remote-tracking branch 'upstream/main' into ro-span-export

    @MrAlias
    MrAlias committed May 3, 2021
    Configuration menu
    Copy the full SHA
    0948442 View commit details
    Browse the repository at this point in the history

  2. Update CHANGELOG with changes

    @MrAlias
    MrAlias committed May 3, 2021
    Configuration menu
    Copy the full SHA
    973ec4f View commit details
    Browse the repository at this point in the history

Commits on May 4, 2021

  1. Merge branch 'main' into ro-span-export

    @MrAlias
    MrAlias authored May 4, 2021
    Configuration menu
    Copy the full SHA
    12e2199 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into ro-span-export

    @MrAlias
    MrAlias authored May 4, 2021
    Configuration menu
    Copy the full SHA
    536e72b View commit details
    Browse the repository at this point in the history

  3. Fix failure from sync with main

    @MrAlias
    MrAlias committed May 4, 2021
    Configuration menu
    Copy the full SHA
    187e4c0 View commit details
    Browse the repository at this point in the history