-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI builds validate against last two versions of Go, dropping 1.14 and adding 1.16 #1865
Conversation
Can you update the list of tested versions in the README? |
@Aneurysm9 updated README |
Codecov Report
@@ Coverage Diff @@
## main #1865 +/- ##
=======================================
+ Coverage 79.0% 79.2% +0.2%
=======================================
Files 139 139
Lines 7477 7459 -18
=======================================
+ Hits 5909 5910 +1
+ Misses 1322 1303 -19
Partials 246 246
|
I had initially added that this can skip the change log, but if we are going to change the minimum version of Go that we support we definitely need to include that in the changelog. |
I'm a bit hesitant to make this change. By moving the minimum version number from 1.14 to 1.15 we are reducing the versions of Go we support and consequentially the number of users we can support here. If our goal is to promote as wide adoption of the project as we can achieve, this goes against that goal. |
… adding 1.16 Signed-off-by: Gábor Lipták <gliptak@gmail.com>
Given that there may be issues related to changes in go-1.16 module handling, perhaps running tests across the current and two past versions of go is a reasonable solution. |
Supporting 2 versions of golang is in keeping with ecosystem standards, and it's worth noting that we aren't yet GA. once we're GA I could see the argument for supporting .15, .16, and .17 in parallel to accommodate slower movers. Remember golang comes out once per 6 months so that's 12 months of official support per major version (plus 6 months if we support N-2 and not just N-1 once hitting GA). https://www.reddit.com/r/golang/comments/cmb5bp/is_there_an_lts_version_of_go/ |
@Aneurysm9 this is going to need your approval to run the CI and then merge |
From SIG meeting:
|
No description provided.