Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OS description attribute detector #1840

Merged
merged 66 commits into from
Jul 8, 2021
Merged

OS description attribute detector #1840

merged 66 commits into from
Jul 8, 2021

Commits on Apr 24, 2021

  1. Added Linux-specific detector for the os.description attribute

    @nelsonghezzi
    nelsonghezzi committed Apr 24, 2021
    Configuration menu
    Copy the full SHA
    709c79f View commit details
    Browse the repository at this point in the history

  2. Generalized OS description detector with placeholder function for uni… 

    …mplemented OSes
    @nelsonghezzi
    nelsonghezzi committed Apr 24, 2021
    Configuration menu
    Copy the full SHA
    f832b05 View commit details
    Browse the repository at this point in the history

  3. Extended osDescription function to *nix OSes based on golang.org/x/sy… 

    …s/unix
    @nelsonghezzi
    nelsonghezzi committed Apr 24, 2021
    Configuration menu
    Copy the full SHA
    fec276b View commit details
    Browse the repository at this point in the history

  4. Added WithOS resource configuration function to configure all of the … 

    …OS resource attributes
    @nelsonghezzi
    nelsonghezzi committed Apr 24, 2021
    Configuration menu
    Copy the full SHA
    b6b5c38 View commit details
    Browse the repository at this point in the history

  5. Implemented osDescription funtion for Windows OS

    @nelsonghezzi
    nelsonghezzi committed Apr 24, 2021
    Configuration menu
    Copy the full SHA
    aee4447 View commit details
    Browse the repository at this point in the history

  6. Improved documentation header for *nix version of the osDescription f… 

    …unction
    @nelsonghezzi
    nelsonghezzi committed Apr 24, 2021
    Configuration menu
    Copy the full SHA
    49b9089 View commit details
    Browse the repository at this point in the history

  7. Added support for reading os-release file

    @nelsonghezzi
    nelsonghezzi committed Apr 24, 2021
    Configuration menu
    Copy the full SHA
    e971536 View commit details
    Browse the repository at this point in the history

  8. Added/updated documentation headers for *nix implementation of osDesc… 

    …ription and related functions
    @nelsonghezzi
    nelsonghezzi committed Apr 24, 2021
    Configuration menu
    Copy the full SHA
    436fcc0 View commit details
    Browse the repository at this point in the history

  9. Changelog update

    @nelsonghezzi
    nelsonghezzi committed Apr 24, 2021
    Configuration menu
    Copy the full SHA
    ab57861 View commit details
    Browse the repository at this point in the history

  10. Added support for reading macOS version information

    @nelsonghezzi
    nelsonghezzi committed Apr 24, 2021
    Configuration menu
    Copy the full SHA
    e2f72c5 View commit details
    Browse the repository at this point in the history

  11. Mock approach to test OS description attribute

    @nelsonghezzi
    nelsonghezzi committed Apr 24, 2021
    Configuration menu
    Copy the full SHA
    a7f2ed0 View commit details
    Browse the repository at this point in the history

  12. Extracted common function getFirstAvailableFile to read the first ava… 

    …ilable file from a list of candidates
    @nelsonghezzi
    nelsonghezzi committed Apr 24, 2021
    Configuration menu
    Copy the full SHA
    01e0dfe View commit details
    Browse the repository at this point in the history

  13. Upgraded golang.org/x/sys

    @nelsonghezzi
    nelsonghezzi committed Apr 24, 2021
    Configuration menu
    Copy the full SHA
    8dee3b9 View commit details
    Browse the repository at this point in the history

  14. Changelog update

    @nelsonghezzi
    nelsonghezzi committed Apr 24, 2021
    Configuration menu
    Copy the full SHA
    5916293 View commit details
    Browse the repository at this point in the history

  15. Fixed wrong function name in documentation header for WithOSDescription

    @nelsonghezzi
    nelsonghezzi committed Apr 24, 2021
    Configuration menu
    Copy the full SHA
    980c1fb View commit details
    Browse the repository at this point in the history

  16. Updated documentation header for platformOSDescription function

    @nelsonghezzi
    nelsonghezzi committed Apr 24, 2021
    Configuration menu
    Copy the full SHA
    2b5d38f View commit details
    Browse the repository at this point in the history

  17. Renamed restoreProcessAttributesProviders test helper function 

    The function restoreProcessAttributesProviders was renamed to simply
restoreAttributesProviders to better reflect its broader scope, which
not only applies to process attribute's providers.
    @nelsonghezzi
    nelsonghezzi committed Apr 24, 2021
    Configuration menu
    Copy the full SHA
    866d3d3 View commit details
    Browse the repository at this point in the history

  18. Fixed os_linux.go overriding build tags defined inside the file 

    The suffix on os_linux.go was overriding the build tags already defined
in that file. The file was renamed to os_release_unix.go, reflecting
the main function defined in the file.

For consistency, os_darwin.go was renamed to os_release_darwing.go, as
its primary purpose is to also define the osRelease function.
    @nelsonghezzi
    nelsonghezzi committed Apr 24, 2021
    Configuration menu
    Copy the full SHA
    8405d78 View commit details
    Browse the repository at this point in the history

Commits on May 5, 2021

  1. Merge remote-tracking branch 'upstream/main' into feature/os-descript… 

    …ion-attribute-detector
    @nelsonghezzi
    nelsonghezzi committed May 5, 2021
    Configuration menu
    Copy the full SHA
    55b8c81 View commit details
    Browse the repository at this point in the history

  2. Removed use of discontinued function resource.WithoutBuiltin

    @nelsonghezzi
    nelsonghezzi committed May 5, 2021
    Configuration menu
    Copy the full SHA
    256e537 View commit details
    Browse the repository at this point in the history

  3. Added PR number to changelog entries

    @nelsonghezzi
    nelsonghezzi committed May 5, 2021
    Configuration menu
    Copy the full SHA
    fc7c4d9 View commit details
    Browse the repository at this point in the history

Commits on May 6, 2021

  1. Updated go.sum files after run of make lint

    @nelsonghezzi
    nelsonghezzi committed May 6, 2021
    Configuration menu
    Copy the full SHA
    d056927 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into feature/os-description-attribute-detector

    @Aneurysm9
    Aneurysm9 authored May 6, 2021
    Configuration menu
    Copy the full SHA
    be6b1df View commit details
    Browse the repository at this point in the history

  3. Linux implementation: ignore lines with an empty key

    @nelsonghezzi
    nelsonghezzi committed May 6, 2021
    Configuration menu
    Copy the full SHA
    b1aba90 View commit details
    Browse the repository at this point in the history

  4. Linux implementation: avoid unquoting strings less than two chars

    @nelsonghezzi
    nelsonghezzi committed May 6, 2021
    Configuration menu
    Copy the full SHA
    4627208 View commit details
    Browse the repository at this point in the history

  5. WIP: added tests for Linux support functions

    @nelsonghezzi
    nelsonghezzi committed May 6, 2021
    Configuration menu
    Copy the full SHA
    3bb7e6a View commit details
    Browse the repository at this point in the history

Commits on May 7, 2021

  1. WIP: added tests for charsToString and getFirstAvailableFile functions

    @nelsonghezzi
    nelsonghezzi committed May 7, 2021
    Configuration menu
    Copy the full SHA
    b14ed7c View commit details
    Browse the repository at this point in the history

  2. Replaced os.CreateTemp with ioutil.TempFile as the former only exists… 

    … in Go 1.16
    @nelsonghezzi
    nelsonghezzi committed May 7, 2021
    Configuration menu
    Copy the full SHA
    725d90f View commit details
    Browse the repository at this point in the history

  3. Added unameProvider type to decouple direct reference to unix.Uname f… 

    …unction inside Uname()
    @nelsonghezzi
    nelsonghezzi committed May 7, 2021
    Configuration menu
    Copy the full SHA
    05d0fbd View commit details
    Browse the repository at this point in the history

  4. Added tests for Uname() function

    @nelsonghezzi
    nelsonghezzi committed May 7, 2021
    Configuration menu
    Copy the full SHA
    de1f693 View commit details
    Browse the repository at this point in the history

  5. Replaced *os.File with io.Reader in parseOSReleaseFile to ease testing

    @nelsonghezzi
    nelsonghezzi committed May 7, 2021
    Configuration menu
    Copy the full SHA
    885e118 View commit details
    Browse the repository at this point in the history

  6. Added tests for parseOSReleaseFile function

    @nelsonghezzi
    nelsonghezzi committed May 7, 2021
    Configuration menu
    Copy the full SHA
    b56ad85 View commit details
    Browse the repository at this point in the history

  7. Darwin implementation: added tests for buildOSRelease function

    @nelsonghezzi
    nelsonghezzi committed May 7, 2021
    Configuration menu
    Copy the full SHA
    c68d0be View commit details
    Browse the repository at this point in the history

Commits on May 11, 2021

  1. Replaced *os.File with io.Reader in parsePlistFile to ease testing

    @nelsonghezzi
    nelsonghezzi committed May 11, 2021
    Configuration menu
    Copy the full SHA
    a03512d View commit details
    Browse the repository at this point in the history

  2. Darwin implementation: added tests for parsePlistFile function

    @nelsonghezzi
    nelsonghezzi committed May 11, 2021
    Configuration menu
    Copy the full SHA
    2f0e0b3 View commit details
    Browse the repository at this point in the history

  3. Type in documentation header for Linux osRelease function

    @nelsonghezzi
    nelsonghezzi committed May 11, 2021
    Configuration menu
    Copy the full SHA
    357c706 View commit details
    Browse the repository at this point in the history

Commits on May 16, 2021

  1. Merge remote-tracking branch 'upstream/main' into feature/os-descript… 

    …ion-attribute-detector
    @nelsonghezzi
    nelsonghezzi committed May 16, 2021
    Configuration menu
    Copy the full SHA
    bec560d View commit details
    Browse the repository at this point in the history

Commits on May 25, 2021

  1. Extracted logic for reading specific registry values into helper func… 

    …tions
    @nelsonghezzi
    nelsonghezzi committed May 25, 2021
    Configuration menu
    Copy the full SHA
    e7b8538 View commit details
    Browse the repository at this point in the history

  2. Added basic tests for Windows version of platformOSDescription and he… 

    …lper functions
    @nelsonghezzi
    nelsonghezzi committed May 25, 2021
    Configuration menu
    Copy the full SHA
    258e879 View commit details
    Browse the repository at this point in the history

  3. Merge remote-tracking branch 'upstream/main' into feature/os-descript… 

    …ion-attribute-detector
    @nelsonghezzi
    nelsonghezzi committed May 25, 2021
    Configuration menu
    Copy the full SHA
    c31cfc6 View commit details
    Browse the repository at this point in the history

  4. Manually formatted uint64 to strings to have an uniform interface for… 

    … test assertions
    @nelsonghezzi
    nelsonghezzi committed May 25, 2021
    Configuration menu
    Copy the full SHA
    5698880 View commit details
    Browse the repository at this point in the history

Commits on May 26, 2021

  1. Asserts there's no error when opening registry key for testing 

    Co-authored-by: Robert Pająk <pellared@hotmail.com>
    @nelsonghezzi @pellared
    nelsonghezzi and pellared authored May 26, 2021
    Configuration menu
    Copy the full SHA
    8d67eb9 View commit details
    Browse the repository at this point in the history

  2. Simplified subtests by using a single test with multiple asserts

    @nelsonghezzi
    nelsonghezzi committed May 26, 2021
    Configuration menu
    Copy the full SHA
    983e5b3 View commit details
    Browse the repository at this point in the history

Commits on May 27, 2021

  1. Merge remote-tracking branch 'upstream/main' into feature/os-descript… 

    …ion-attribute-detector
    @nelsonghezzi
    nelsonghezzi committed May 27, 2021
    Configuration menu
    Copy the full SHA
    3595fdf View commit details
    Browse the repository at this point in the history

  2. go.sum update after running make

    @nelsonghezzi
    nelsonghezzi committed May 27, 2021
    Configuration menu
    Copy the full SHA
    29fcffa View commit details
    Browse the repository at this point in the history

Commits on May 28, 2021

  1. Merge remote-tracking branch 'upstream/main' into feature/os-descript… 

    …ion-attribute-detector
    @nelsonghezzi
    nelsonghezzi committed May 28, 2021
    Configuration menu
    Copy the full SHA
    eedc291 View commit details
    Browse the repository at this point in the history

Commits on Jun 3, 2021

  1. Merge remote-tracking branch 'upstream/main' into feature/os-descript… 

    …ion-attribute-detector
    @nelsonghezzi
    nelsonghezzi committed Jun 3, 2021
    Configuration menu
    Copy the full SHA
    3446fce View commit details
    Browse the repository at this point in the history

Commits on Jun 10, 2021

  1. Fix typo 

    Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
    @nelsonghezzi @MrAlias
    nelsonghezzi and MrAlias authored Jun 10, 2021
    Configuration menu
    Copy the full SHA
    832606a View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'upstream/main' into feature/os-descript… 

    …ion-attribute-detector
    @nelsonghezzi
    nelsonghezzi committed Jun 10, 2021
    Configuration menu
    Copy the full SHA
    d797a6e View commit details
    Browse the repository at this point in the history

  3. WIP: added placeholder implementation of platformOSDescription for un… 

    …supported OSes
    @nelsonghezzi
    nelsonghezzi committed Jun 10, 2021
    Configuration menu
    Copy the full SHA
    a42f424 View commit details
    Browse the repository at this point in the history

Commits on Jun 21, 2021

  1. Fixed typo on osRelease documentation header 

    Co-authored-by: Chris Bandy <bandy.chris@gmail.com>
    @nelsonghezzi @cbandy
    nelsonghezzi and cbandy authored Jun 21, 2021
    Configuration menu
    Copy the full SHA
    791e058 View commit details
    Browse the repository at this point in the history

  2. Fixed typo on test case name for ParsePlistFile tests 

    Co-authored-by: Chris Bandy <bandy.chris@gmail.com>
    @nelsonghezzi @cbandy
    nelsonghezzi and cbandy authored Jun 21, 2021
    Configuration menu
    Copy the full SHA
    2bf1370 View commit details
    Browse the repository at this point in the history

  3. Merge remote-tracking branch 'upstream/main' into feature/os-descript… 

    …ion-attribute-detector
    @nelsonghezzi
    nelsonghezzi committed Jun 21, 2021
    Configuration menu
    Copy the full SHA
    f1539fb View commit details
    Browse the repository at this point in the history

  4. Linter fix in changelog

    @nelsonghezzi
    nelsonghezzi committed Jun 21, 2021
    Configuration menu
    Copy the full SHA
    eeac5d9 View commit details
    Browse the repository at this point in the history

  5. go.sum updates after running make

    @nelsonghezzi
    nelsonghezzi committed Jun 21, 2021
    Configuration menu
    Copy the full SHA
    9322a9b View commit details
    Browse the repository at this point in the history

  6. Used strings.Replacer instead of multiple strings.ReplaceAll calls

    @nelsonghezzi
    nelsonghezzi committed Jun 21, 2021
    Configuration menu
    Copy the full SHA
    bd6fcde View commit details
    Browse the repository at this point in the history

Commits on Jun 22, 2021

  1. Optimized implementation of charsToString

    @nelsonghezzi
    nelsonghezzi committed Jun 22, 2021
    Configuration menu
    Copy the full SHA
    1ce3654 View commit details
    Browse the repository at this point in the history

  2. Safer temporary file deletion with t.TempDir()

    @nelsonghezzi
    nelsonghezzi committed Jun 22, 2021
    Configuration menu
    Copy the full SHA
    ea07b21 View commit details
    Browse the repository at this point in the history

  3. Used t.Cleanup() for safer mocking of runtime providers in OS resourc… 

    …e tests
    @nelsonghezzi
    nelsonghezzi committed Jun 22, 2021
    Configuration menu
    Copy the full SHA
    f94b783 View commit details
    Browse the repository at this point in the history

  4. Handled optionality of DisplayVersion registry key. 

    For example, CI machine runs on:
Windows Server 2019 Datacenter (1809) [Version 10.0.17763.1999]

So, to not add an extra white space due to missing DisplayVersion,
this value is checked to be not empty, and only in such case a
trailing space is added for that component.
    @nelsonghezzi
    nelsonghezzi committed Jun 22, 2021
    Configuration menu
    Copy the full SHA
    0846d68 View commit details
    Browse the repository at this point in the history

  5. Workaround to handle the case of DisplayVersion registry key not present

    @nelsonghezzi
    nelsonghezzi committed Jun 22, 2021
    Configuration menu
    Copy the full SHA
    c33a6e9 View commit details
    Browse the repository at this point in the history

  6. Merge remote-tracking branch 'upstream/main' into feature/os-descript… 

    …ion-attribute-detector
    @nelsonghezzi
    nelsonghezzi committed Jun 22, 2021
    Configuration menu
    Copy the full SHA
    739b468 View commit details
    Browse the repository at this point in the history

  7. Excluded unsupported GOOSes by negation of supported ones

    @nelsonghezzi
    nelsonghezzi committed Jun 22, 2021
    Configuration menu
    Copy the full SHA
    a0ab941 View commit details
    Browse the repository at this point in the history

  8. go.sum update after running make

    @nelsonghezzi
    nelsonghezzi committed Jun 22, 2021
    Configuration menu
    Copy the full SHA
    b100dac View commit details
    Browse the repository at this point in the history

Commits on Jul 3, 2021

  1. Merge remote-tracking branch 'upstream/main' into feature/os-descript… 

    …ion-attribute-detector
    @nelsonghezzi
    nelsonghezzi committed Jul 3, 2021
    Configuration menu
    Copy the full SHA
    764f148 View commit details
    Browse the repository at this point in the history

Commits on Jul 8, 2021

  1. Merge branch 'main' into feature/os-description-attribute-detector

    @Aneurysm9
    Aneurysm9 authored Jul 8, 2021
    Configuration menu
    Copy the full SHA
    1e7645f View commit details
    Browse the repository at this point in the history