Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove bundler from Jaeger exporter #1830

Merged
merged 6 commits into from
Apr 22, 2021

Conversation

MrAlias
Copy link
Contributor

@MrAlias MrAlias commented Apr 20, 2021

Resolve #1799
Resolve #1803

  • Remove the bundler from the Jaeger exporter including all the configuration options.
  • Remove the Option type from the Jaeger exporter, it is not used.
  • Fix the close of the exporter close channel. Only close it once and avoid the panic if tried more than once.

@MrAlias MrAlias added release:1.0.0-rc.1 pkg:exporter:jaeger Related to the Jaeger exporter package labels Apr 20, 2021
@MrAlias MrAlias added this to the RC1 milestone Apr 20, 2021
@MrAlias MrAlias requested a review from Aneurysm9 as a code owner April 20, 2021 23:54
@codecov
Copy link

codecov bot commented Apr 20, 2021

Codecov Report

Merging #1830 (f922941) into main (738ef11) will decrease coverage by 0.0%.
The diff coverage is 33.3%.

Impacted file tree graph

@@           Coverage Diff           @@
##            main   #1830     +/-   ##
=======================================
- Coverage   78.4%   78.3%   -0.1%     
=======================================
  Files        135     135             
  Lines       7246    7220     -26     
=======================================
- Hits        5684    5657     -27     
- Misses      1315    1318      +3     
+ Partials     247     245      -2     
Impacted Files Coverage Δ
exporters/trace/jaeger/uploader.go 32.0% <0.0%> (-5.0%) ⬇️
exporters/trace/jaeger/jaeger.go 92.3% <75.0%> (+2.8%) ⬆️
sdk/trace/batch_span_processor.go 83.9% <0.0%> (ø)

@Aneurysm9 Aneurysm9 merged commit 0fdc3d7 into open-telemetry:main Apr 22, 2021
@MrAlias MrAlias deleted the jaeger-rm-bundler branch April 22, 2021 15:06
This was referenced Apr 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg:exporter:jaeger Related to the Jaeger exporter package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove the bundler from the Jaeger exporter
3 participants