-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add support for env var configuration to otlp/gRPC #1811
add support for env var configuration to otlp/gRPC #1811
Conversation
paivagustavo
commented
Apr 14, 2021
•
edited
Loading
edited
- Added env var config to the otlp/gRPC driver.
- I did a small refactor to the otlp/HTTP options to make it reusable in the otlp/gRPC driver.
- Since I needed to refactor both drivers to accept different connection and configuration when sending data to traces and metrics, I've also added some more context to some errors.
Codecov Report
@@ Coverage Diff @@
## main #1811 +/- ##
=======================================
- Coverage 78.6% 78.4% -0.2%
=======================================
Files 134 135 +1
Lines 7158 7236 +78
=======================================
+ Hits 5630 5679 +49
- Misses 1278 1307 +29
Partials 250 250
|
I've just noticed that this does implement the |
Does this mean that #1085 should not be closed by this PR @paivagustavo? |
Yes, I'll update this PR description to not close the issue. |