-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
change jaeger options to functional style #161
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paivagustavo
requested review from
bogdandrutu,
jmacd,
pjanotti,
rghetia,
sjkaris and
tedsuo
as code owners
October 3, 2019 07:25
rghetia
reviewed
Oct 3, 2019
@rghetia I've changed what you request, could you review it again? |
rghetia
approved these changes
Oct 3, 2019
ymotongpoo
added a commit
to ymotongpoo/opentelemetry-go
that referenced
this pull request
Oct 4, 2019
passing option struct directly. This fix is aliging the same fix for Jaeger (#146, open-telemetry#161) * Change Option struct to be function type * Change the original Option struct to be private
ymotongpoo
added a commit
to ymotongpoo/opentelemetry-go
that referenced
this pull request
Oct 4, 2019
passing option struct directly. This fix is aliging the same fix for Jaeger (#146, open-telemetry#161) * Change Option struct to be function type * Change the original Option struct to be private
jmacd
approved these changes
Oct 4, 2019
ymotongpoo
added a commit
to ymotongpoo/opentelemetry-go
that referenced
this pull request
Oct 8, 2019
passing option struct directly. This fix is aliging the same fix for Jaeger (#146, open-telemetry#161) * Change Option struct to be function type * Change the original Option struct to be private
ymotongpoo
added a commit
to ymotongpoo/opentelemetry-go
that referenced
this pull request
Oct 8, 2019
passing option struct directly. This fix is aliging the same fix for Jaeger (#146, open-telemetry#161) * Change Option struct to be function type * Change the original Option struct to be private
rghetia
pushed a commit
that referenced
this pull request
Oct 9, 2019
* Add Stackdriver Trace exporter for trace. TODOs for future work is: * to replace bundler.Bundler * to add proper tests for the exporter * to move the exporter to proper repository once it will be created. * Change to use functions for the exporter initialization instead of passing option struct directly. This fix is aliging the same fix for Jaeger (#146, #161) * Change Option struct to be function type * Change the original Option struct to be private * Add line comments to maxMessageEventsPerSpan to leave it for future implementation * Fix unnessesary expressions specified by `make precommit` Left errors by `make precommit` in experimental/bridge/opentracing. * Ran make precommit * Add new line at EOF * WIP: Start implementing BatchSpanExporter interfaces * Change to use RegisterSpanProcessor to register bsp * Change function names to fit current implementation of sdk * Removed google.golang.org/api/support/bundler and implement ssp and bsp * Change spanProcessor as a member of Exporter. * Fix option names used for BatchSpanProcessor initialization. * Change Exporter.Shutdown just to unregister spanProcessor. * Removed copyright statements of OpenCensus. * Fix small typo and EOF new line * Fix interfaces of ExportSpan/ExportSpans to meet SpanSyncer/SpanBatcher * Change to follow context.Context passed in ExportSpan/ExportSpans * Fix Stackdriver Exporter to hold sync.Once to lock when it is registered and unregistered.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #146
With this i have separated the Options struct in 3:
Every exporter must pass one, and only one, endpoint (through the
EndpointOption
). The new signature is:Usage examples:
I have also extracted the upload to an interface:
The
EndpointOption
generates an implementation ofbatchUploader
based on the option passed by the user.