Shutdown underlying span exporter while shutting down BatchSpanProcessor #1443
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
XSAM
requested review from
Aneurysm9,
dashpole,
evantorrie,
jmacd,
lizthegrey and
MrAlias
as code owners
XSAM
force-pushed
the
fix/batch-span-processor
branch
2 times, most recently
from
13b72ab
to
76d4e5e
Compare
Codecov Report
@@ Coverage Diff @@
## master #1443 +/- ##
========================================
- Coverage 78.9% 78.9% -0.1%
========================================
Files 128 128
Lines 6664 6666 +2
========================================
Hits 5263 5263
- Misses 1147 1148 +1
- Partials 254 255 +1
|
XSAM
force-pushed
the
fix/batch-span-processor
branch
from
76d4e5e
to
213311d
Compare
dashpole
approved these changes
Jan 8, 2021
Aneurysm9
approved these changes
Jan 12, 2021
Co-authored-by: Anthony Mirabella <a9@aneurysm9.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1423