Metric histogram aggregator: Swap in SynchronizedMove to avoid allocations #1435
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmacd
requested review from
Aneurysm9,
dashpole,
evantorrie,
lizthegrey,
MrAlias and
XSAM
as code owners
Codecov Report
@@ Coverage Diff @@
## master #1435 +/- ##
========================================
- Coverage 79.2% 78.9% -0.3%
========================================
Files 128 128
Lines 6642 6672 +30
========================================
+ Hits 5263 5269 +6
- Misses 1124 1148 +24
Partials 255 255
|
evantorrie
approved these changes
Jan 5, 2021
| // lock below. | ||
| o.clearState() | ||
| } | ||
|
|
||
| c.lock.Lock() |
There was a problem hiding this comment.
Is the SynchronizedMove function comment still true? "Since no locks are taken, there is a chance that the independent Sum, Count and Bucket Count are not consistent with each other."
|
@bogdandrutu Please review. |
XSAM
reviewed
Jan 6, 2021
Co-authored-by: Sam Xie <xsambundy@gmail.com>
bogdandrutu
reviewed
Jan 6, 2021
| @@ -38,7 +38,7 @@ type ( | |||
| lock sync.Mutex | |||
| boundaries []float64 | |||
| kind number.Kind | |||
| state state | |||
| state *state | |||
There was a problem hiding this comment.
State has only 40B, not sure you need to use pointer here.
dashpole
approved these changes
Jan 7, 2021
XSAM
approved these changes
Jan 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The target Aggregator of a
SynchronizedMove(for synchronous instruments, typicallyValueRecorder) has a reference to a slice that is effectively discarded. This PR avoids that by recycling the allocated slice when possible.