Add Tracestate into the SamplingResult struct #1432
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ozerovandrei
requested review from
Aneurysm9,
dashpole,
evantorrie,
jmacd,
lizthegrey,
MrAlias and
XSAM
as code owners
Codecov Report
@@ Coverage Diff @@
## master #1432 +/- ##
======================================
Coverage 78.6% 78.6%
======================================
Files 126 126
Lines 6367 6375 +8
======================================
+ Hits 5009 5017 +8
Misses 1114 1114
Partials 244 244
|
Aneurysm9
approved these changes
Jan 3, 2021
XSAM
approved these changes
Jan 3, 2021
jmacd
approved these changes
Jan 6, 2021
Add `trace.Tracestate` field into the SDK `trace.SamplingResult` struct. Use ParentContext from SamplingParameters to return Tracestate in `traceIDRatioSampler`, `alwaysOnSampler` and `alwaysOffSampler`. Add a new test to check that Tracestate is passed.
Added changes description for open-telemetry#1432.
ozerovandrei
force-pushed
the
1341-tracestate-in-samplingresult
branch
from
fa10b10
to
99cd9ce
Compare
|
Rebased. |
MrAlias
approved these changes
Jan 6, 2021
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
trace.Tracestatefield into the SDKtrace.SamplingResultstruct.Use ParentContext from SamplingParameters to return Tracestate in
traceIDRatioSampler,alwaysOnSamplerandalwaysOffSampler.Add a new test to check that Tracestate is passed.
Fixes #1341