Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify endpoint API that related to OTel exporter #1401

Merged
merged 7 commits into from
Dec 29, 2020

Conversation

XSAM
Copy link
Member

@XSAM XSAM commented Dec 15, 2020

Fix #1345

@codecov
Copy link

codecov bot commented Dec 15, 2020

Codecov Report

Merging #1401 (a189f98) into master (045c3ff) will decrease coverage by 0.0%.
The diff coverage is 100.0%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #1401     +/-   ##
========================================
- Coverage    78.6%   78.5%   -0.1%     
========================================
  Files         126     126             
  Lines        6369    6369             
========================================
- Hits         5011    5005      -6     
- Misses       1114    1120      +6     
  Partials      244     244             
Impacted Files Coverage Δ
exporters/otlp/grpcconnection.go 85.9% <100.0%> (ø)
exporters/otlp/grpcdriver.go 90.1% <100.0%> (ø)
exporters/otlp/grpcoptions.go 87.5% <100.0%> (ø)
sdk/trace/batch_span_processor.go 74.5% <0.0%> (-5.9%) ⬇️

example/otel-collector/main.go Outdated Show resolved Hide resolved
exporters/otlp/mock_collector_test.go Outdated Show resolved Hide resolved
@MrAlias MrAlias merged commit 5c9221c into open-telemetry:master Dec 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

otlp.ExporterOption WithAddress should be renamed to WithEndpoint
3 participants