Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Call otel.Handle with non-nil errors #1384

Merged
merged 3 commits into from
Dec 11, 2020
Merged

Call otel.Handle with non-nil errors #1384

merged 3 commits into from
Dec 11, 2020

Commits on Dec 7, 2020

  1. Call otel.Handle with non-nil errors 

    That's what normally happens in other call sites. Those two didn't
check it, but passed the "error" to Handle. The default, delegating
implementation of ErrorHandler was printing the error unconditionally,
which resulted in pointless lines like `2020/12/07 19:51:28 <nil>` in
demos, for example.
    @krnowak
    krnowak committed Dec 7, 2020
    Configuration menu
    Copy the full SHA
    60f89ca View commit details
    Browse the repository at this point in the history

  2. Add tests

    @krnowak
    krnowak committed Dec 7, 2020
    Configuration menu
    Copy the full SHA
    b77f493 View commit details
    Browse the repository at this point in the history

Commits on Dec 11, 2020

  1. Merge branch 'master' into handle-non-nil-err

    @MrAlias
    MrAlias authored Dec 11, 2020
    Configuration menu
    Copy the full SHA
    a5e14e4 View commit details
    Browse the repository at this point in the history