Build examples last #1370
Merged
Build examples last #1370
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krnowak
requested review from
Aneurysm9,
evantorrie,
jmacd,
lizthegrey,
MrAlias and
XSAM
as code owners
|
Not adding changelog here. |
dashpole
approved these changes
Nov 30, 2020
XSAM
approved these changes
Dec 1, 2020
Examples are "leaf" packages, that pull some other packages. So build the other packages first to get and fix all the errors there, before building the examples.
krnowak
force-pushed
the
build-examples-last
branch
from
3282122
to
80f955c
Compare
Codecov Report
@@ Coverage Diff @@
## master #1370 +/- ##
======================================
Coverage 77.6% 77.6%
======================================
Files 124 124
Lines 6128 6128
======================================
+ Hits 4756 4760 +4
+ Misses 1121 1116 -5
- Partials 251 252 +1
|
AzfaarQureshi
pushed a commit
to open-o11y/opentelemetry-go
that referenced
this pull request
Dec 3, 2020
Examples are "leaf" packages, that pull some other packages. So build the other packages first to get and fix all the errors there, before building the examples.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Examples are "leaf" packages, that pull some other packages. So build
the other packages first to get and fix all the errors there, before
building the examples.