Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add OpenCensus bridge example to gitignore #1358

Closed
wants to merge 1 commit into from

Conversation

MrAlias
Copy link
Contributor

@MrAlias MrAlias commented Nov 20, 2020

No description provided.

@MrAlias MrAlias added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Nov 20, 2020
@codecov
Copy link

codecov bot commented Nov 20, 2020

Codecov Report

Merging #1358 (fb0b400) into master (575df22) will increase coverage by 0.0%.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #1358   +/-   ##
======================================
  Coverage    77.4%   77.5%           
======================================
  Files         124     124           
  Lines        6104    6104           
======================================
+ Hits         4730    4734    +4     
+ Misses       1125    1120    -5     
- Partials      249     250    +1     
Impacted Files Coverage Δ
sdk/trace/batch_span_processor.go 78.4% <0.0%> (+3.9%) ⬆️

@krnowak
Copy link
Member

krnowak commented Nov 20, 2020

Heh, I filed #1359 with this change too, but I have moved the example to the examples directory. I'll leave it to you to decide which one to use.

@krnowak
Copy link
Member

krnowak commented Nov 20, 2020

And seriously, codecov reports boggle my mind.

@MrAlias
Copy link
Contributor Author

MrAlias commented Nov 20, 2020

#1359 looks like the better version of this. Let's go with that.

@MrAlias MrAlias closed this Nov 20, 2020
@MrAlias MrAlias deleted the gitignore branch November 20, 2020 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants