chore(zipkin-exporter): relay on the status code for the request but still read the response body.

[jcchavezs]

This is a port from #1319

Ping @MrAlias

[jcchavezs]

Can we merge this @MrAlias?

[Aneurysm9]

Can we merge this @MrAlias?

This is not yet ready for merging. It does not have two approvals, it does not have a changelog entry or the Skip Changelog label, the CI build is failing due to a compile error, and it is not able to be applied to the trunk as a fast-forward.

[jcchavezs]

This is not yet ready for merging. It does not have two approvals, it does not have a changelog entry or the Skip Changelog label, the CI build is failing due to a compile error, and it is not able to be applied to the trunk as a fast-forward.

My bad, I misinterpreted the CI result and I thought it was only missing the changelog label. Fixing it now.

[codecov]

Codecov Report

Merging #1328 (f957f56) into master (66db2d8) will increase coverage by 0.0%.
The diff coverage is 75.0%.

@@          Coverage Diff           @@
##           master   #1328   +/-   ##
======================================
  Coverage    77.6%   77.6%           
======================================
  Files         124     124           
  Lines        6128    6126    -2     
======================================
- Hits         4756    4755    -1     
+ Misses       1121    1120    -1     
  Partials      251     251           

Impacted Files	Coverage Δ
exporters/trace/zipkin/zipkin.go	73.6% <75.0%> (+0.6%)	⬆️

[MrAlias]

LGTM overall.

[jcchavezs]

Shall we merge it?

[XSAM]

Shall we merge it?

Please add a CHANGELOG entry. :)

[jcchavezs]

@XSAM done

[XSAM]

@jcchavezs There are some comments that need to solve. It looks like forced push overwrites these changes.

e.g. 202 -> http.StatusAccepted

[jcchavezs]

@XSAM yeah I just saw it. Fixed them.

[XSAM]

LGTM

@Aneurysm9 @MrAlias I believe we should merge this PR.

[jcchavezs]

Shall we?

[MrAlias]

Thanks for the contribution @jcchavezs! Sorry about the delay getting it merged.

[jcchavezs]

Thanks.

…

On Thu, 3 Dec 2020, 18:52 Tyler Yahn, ***@***.***> wrote: Thanks for the contribution @jcchavezs <https://github.com/jcchavezs>! Sorry about the delay getting it merged. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#1328 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAXOYAVRQFB5DXO2PAL6QXTSS7F4LANCNFSM4TTVQRKA> .