Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move examples to contrib #5801

Closed
5 tasks done
pellared opened this issue Sep 10, 2024 · 3 comments · Fixed by #5930
Closed
5 tasks done

Move examples to contrib #5801

pellared opened this issue Sep 10, 2024 · 3 comments · Fixed by #5930
Assignees
@pellared
Labels
area:logs Part of OpenTelemetry logs pkg:example Related to an example
Milestone
v1.32.0

Comments

@pellared
Copy link
Member

pellared commented Sep 10, 2024 •
edited
Loading

A follow-up after #5791 in contrib is required and afterwards here we need to fix the example/dice.
@pellared pellared added area:logs Part of OpenTelemetry logs pkg:example Related to an example labels Sep 10, 2024
@pellared pellared mentioned this issue Sep 10, 2024
Merged
@pellared pellared moved this from Todo to Blocked in Go: Logs (GA) Sep 10, 2024
@MrAlias
Copy link
Contributor

MrAlias commented Sep 11, 2024

This round-about dependency seems like something we should address. Should this example be moved to contrib? Should all examples?

@pellared
Copy link
Member Author

This round-about dependency seems like something we should address. Should this example be moved to contrib?

It makes sense also because this example also uses go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp

Should all examples?

It may be indeed easier to keep all examples in contrib.

@pellared pellared mentioned this issue Sep 12, 2024
Closed
@dashpole
Copy link
Contributor

I'm OK with moving examples to contrib

@pellared pellared moved this from Blocked to Todo in Go: Logs (GA) Sep 13, 2024
@pellared pellared self-assigned this Sep 13, 2024
@pellared pellared changed the title example/dice: Revert otelslog bridge Move examples to contrib Sep 13, 2024
@pellared pellared mentioned this issue Sep 27, 2024
Merged
pellared added a commit to open-telemetry/opentelemetry-go-contrib that referenced this issue Sep 29, 2024
@pellared
Move examples from core repository (#6158)
f074513 
Towards open-telemetry/opentelemetry-go#5801
This was referenced Sep 30, 2024
Merged
Merged
Merged
@pellared pellared added this to the v1.32.0 milestone Sep 30, 2024
pellared added a commit that referenced this issue Oct 1, 2024
@pellared
Deprecate examples and redirect to contrib (#5854)
d7e7da6 
Towards #5801
pellared added a commit to open-telemetry/opentelemetry-go-contrib that referenced this issue Oct 1, 2024
@pellared
dice: Revert otelslog usage (#6162)
21b406f 
Towards open-telemetry/opentelemetry-go#5801
pellared added a commit to open-telemetry/opentelemetry-go-contrib that referenced this issue Oct 1, 2024
@pellared
[chore] Add verify_examples.sh (#6160)
a39b8d8 
Towards open-telemetry/opentelemetry-go#5801

Leftover after
#6158
@pellared pellared removed this from Go: Logs (GA) Oct 3, 2024
@robinlieb robinlieb mentioned this issue Oct 9, 2024
Merged
@pellared pellared mentioned this issue Oct 30, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pellared pellared

Labels
area:logs Part of OpenTelemetry logs pkg:example Related to an example
Projects
None yet
Milestone
v1.32.0
Development

Successfully merging a pull request may close this issue.

Remove examples pellared/opentelemetry-go
3 participants
@dashpole @pellared @MrAlias