-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
otlpmetrichttp exporter is sending generic error msg instead of actual collector msg in case of using loadbalancer exporter #5536
Comments
PR for the fix: #5541 |
mark-pictor-csec
added a commit
to mark-pictor-csec/opentelemetry-go
that referenced
this issue
Oct 29, 2024
PR open-telemetry#5541 (and issue open-telemetry#5536) enhance error handling, returning body text as part of the error. However, this is only done for retryable errors and focuses on a load balancer configuration; error text still does not propagate to clients, and any text for non-retryable errors is always discarded. This PR adds handling of non-retryable errors, ensuring any body text is part of the message returned to the user's code. There is no change to when errors are reported, just an enhancement of the content of such an error.
mark-pictor-csec
added a commit
to mark-pictor-csec/opentelemetry-go
that referenced
this issue
Oct 29, 2024
PR open-telemetry#5541 (and issue open-telemetry#5536) enhance error handling, returning body text as part of the error. However, this is only done for retryable errors; if non-retryable, error text still does not propagate to clients. This PR adds handling of non-retryable errors, ensuring any body text is part of the message returned to the user's code. There is no change to the circumstances under which errors are reported, just an enhancement of the content of such an error.
mark-pictor-csec
added a commit
to mark-pictor-csec/opentelemetry-go
that referenced
this issue
Nov 6, 2024
PR open-telemetry#5541 (and issue open-telemetry#5536) enhance error handling, returning body text as part of the error. However, this is only done for retryable errors; if non-retryable, error text still does not propagate to clients. This PR adds handling of non-retryable errors, ensuring any body text is part of the message returned to the user's code. There is no change to the circumstances under which errors are reported, just an enhancement of the content of such an error.
mark-pictor-csec
added a commit
to mark-pictor-csec/opentelemetry-go
that referenced
this issue
Nov 6, 2024
PR open-telemetry#5541 (and issue open-telemetry#5536) enhance error handling, returning body text as part of the error. However, this is only done for retryable errors; if non-retryable, error text still does not propagate to clients. This PR adds handling of non-retryable errors, ensuring any body text is part of the message returned to the user's code. There is no change to the circumstances under which errors are reported, just an enhancement of the content of such an error.
mark-pictor-csec
added a commit
to mark-pictor-csec/opentelemetry-go
that referenced
this issue
Nov 12, 2024
PR open-telemetry#5541 (and issue open-telemetry#5536) enhance error handling, returning body text as part of the error. However, this is only done for retryable errors; if non-retryable, error text still does not propagate to clients. This PR adds handling of non-retryable errors, ensuring any body text is part of the message returned to the user's code. There is no change to the circumstances under which errors are reported, just an enhancement of the content of such an error.
dmathieu
added a commit
that referenced
this issue
Nov 20, 2024
PR #5541 (and issue #5536) enhance error handling, returning body text as part of the error. However, this is only done for retryable errors; if non-retryable, error text still does not propagate to clients. This PR adds handling of non-retryable errors, ensuring any body text is part of the message returned to the user's code. There is no change to the circumstances under which errors are reported, just an enhancement of the content of such an error. --------- Co-authored-by: Damien Mathieu <42@dmathieu.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Description
If user forget to add attribute service.name while creating resource object using
resource.New
andotlpmetrichttp
with a collector setup of loadbalancing exporter (which uses service for routing purpose), error msg that user receives in scenario doesn't say anything about the actual problem, this is the actual error msg that user getsthis doesn't happen with
otlpmetricgrpc
exporter, it sends the actual error message that comes from collector, this is the error msg.Issue: it is difficult to figure out the actual reason behind the problem and it is happening because underlying collector sends the actual reason in response body, which otlpmetrichttp discards in case of
retryable code
and actual issue behind the failure gets missed.Part1: otlpmetrichttp -----------api call------------> otel-collector (loadbalancer exporter)
Part2: otel-collector --- sends error via---> otlpmetric UploadMetrics func
Part3: otlpmetric UploadMetrics func --- discards body ---> sends error
retry-able request failure
instead of actual errorSetup Details
Environment
Steps To Reproduce
Export env variable
export ENDPOINT_DOMAIN='otel-gateway:4317'
export REMOTE_WRITE_URL='http://victoriametrics:8429/api/v1/write'
Create golang app Dockerfile and build it under myapp in docker compose
docker-compose.yaml
otel-gateway-config.yaml
otel-collector-config.yaml
docker compose up
Make an api call to the myapp on
http://localhost:8081
Expected behavior
Solution will send messages as it is received from collector.
The text was updated successfully, but these errors were encountered: