Skip to content

Commit

Permalink
Add TODO for slimmed down semver.Version use
Browse files Browse the repository at this point in the history
  • Loading branch information
MrAlias committed Sep 21, 2023
1 parent 1f8f5bf commit dfd49dd
Showing 1 changed file with 6 additions and 0 deletions.
6 changes: 6 additions & 0 deletions schema/schema.go
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,9 @@ type Schema struct {
//
// [schema file format]: https://github.com/open-telemetry/opentelemetry-specification/blob/007f415120090972e22a90afd499640321f160f3/specification/schemas/file_format_v1.1.0.md#schema-file-format-number
FileFormat string `yaml:"file_format"`
// TODO: use a slimmed down version of semconv.Version here as a key. We
// convert this value in many places to that type for evaluation, it would
// be better to use the type instead of rely on the conversion later.

// SchemaURL is the [URL] for the Schema file.
//
Expand All @@ -47,6 +50,9 @@ type Schema struct {
// The version string is a semver string matching the release version of
// semantic conventions (e.g. "1.7.0").
Versions map[string]Changeset
// TODO: use a slimmed down version of semconv.Version here as a key. We
// convert this value in many places to that type for evaluation, it would
// be better to use the type instead of rely on the conversion later.
}

var (
Expand Down

0 comments on commit dfd49dd

Please sign in to comment.