Skip to content

Commit

Permalink
[jaeger] Added WithBatchMaxCount as an option (#931)
Browse files Browse the repository at this point in the history
  • Loading branch information
mhr3 authored Jul 10, 2020
1 parent d979977 commit 4dec0ad
Showing 1 changed file with 15 additions and 0 deletions.
15 changes: 15 additions & 0 deletions exporters/trace/jaeger/jaeger.go
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,9 @@ type options struct {
// BufferMaxCount defines the total number of traces that can be buffered in memory
BufferMaxCount int

// BatchMaxCount defines the maximum number of spans sent in one batch
BatchMaxCount int

Config *sdktrace.Config

// RegisterGlobal is set to true if the trace provider of the new pipeline should be
Expand All @@ -65,6 +68,13 @@ func WithBufferMaxCount(bufferMaxCount int) Option {
}
}

// WithBatchMaxCount defines the maximum number of spans in one batch
func WithBatchMaxCount(batchMaxCount int) Option {
return func(o *options) {
o.BatchMaxCount = batchMaxCount
}
}

// WithSDK sets the SDK config for the exporter pipeline.
func WithSDK(config *sdktrace.Config) Option {
return func(o *options) {
Expand Down Expand Up @@ -134,6 +144,11 @@ func NewRawExporter(endpointOption EndpointOption, opts ...Option) (*Exporter, e
bundler.BufferedByteLimit = o.BufferMaxCount
}

// The default value bundler uses is 10, increase to send larger batches
if o.BatchMaxCount != 0 {
bundler.BundleCountThreshold = o.BatchMaxCount
}

e.bundler = bundler
return e, nil
}
Expand Down

0 comments on commit 4dec0ad

Please sign in to comment.