Apply suggestions from code review

open-telemetry · Jan 5, 2023 · 2fcf8cd · 2fcf8cd
1 parent 013a228
commit 2fcf8cd
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 0 deletions.
diff --git a/metric/instrument/asyncfloat64.go b/metric/instrument/asyncfloat64.go
@@ -40,6 +40,11 @@ type Float64Observer interface {
 // The function needs to complete in a finite amount of time and the deadline
 // of the passed context is expected to be honored.
 //
+// The function needs to make unique observations across all registered
+// Float64Callbacks. Meaning, it should not report measurements with the same
+// attributes as another Float64Callbacks also registered for the same
+// instrument.
+//
 // The function needs to be concurrent safe.
 type Float64Callback func(context.Context, Float64Observer) error
 

diff --git a/metric/instrument/asyncint64.go b/metric/instrument/asyncint64.go
@@ -41,6 +41,11 @@ type Int64Observer interface {
 // The function needs to complete in a finite amount of time and the deadline
 // of the passed context is expected to be honored.
 //
+// The function needs to make unique observations across all registered
+// Int64Callback. Meaning, it should not report measurements with the same
+// attributes as another Int64Callbacks also registered for the same
+// instrument.
+//
 // The function needs to be concurrent safe.
 type Int64Callback func(context.Context, Int64Observer) error