Instrument gRPC server span status codes #1127
Open
+215
−40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
damemi
force-pushed
the
grpc-server-status-code
branch
2 times, most recently
from
637da87
to
0863a1e
Compare
MrAlias
approved these changes
Sep 25, 2024
internal/pkg/instrumentation/bpf/google.golang.org/grpc/server/bpf/probe.bpf.c
Outdated
Show resolved
Hide resolved
RonFed
reviewed
Sep 27, 2024
internal/pkg/instrumentation/bpf/google.golang.org/grpc/server/bpf/probe.bpf.c
Outdated
Show resolved
Hide resolved
RonFed
reviewed
Sep 27, 2024
internal/pkg/instrumentation/bpf/google.golang.org/grpc/server/probe.go
Outdated
Show resolved
Hide resolved
damemi
force-pushed
the
grpc-server-status-code
branch
3 times, most recently
from
d4212a2
to
d45da58
Compare
RonFed
reviewed
Oct 19, 2024
internal/pkg/instrumentation/bpf/google.golang.org/grpc/server/bpf/probe.bpf.c
Outdated
Show resolved
Hide resolved
…/bpf/probe.bpf.c Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
damemi
force-pushed
the
grpc-server-status-code
branch
from
02c614e
to
da38f26
Compare
|
Updated based on feedback and sig discussion, ptal! |
damemi
force-pushed
the
grpc-server-status-code
branch
from
4ff185e
to
6676803
Compare
RonFed
approved these changes
Oct 24, 2024
| void *key = get_consistent_key(ctx, go_context.data); | ||
|
|
||
| struct grpc_request_t *grpcReq_event_ptr = bpf_map_lookup_elem(&grpc_events, &key); | ||
| // if grpcReq_event is null, then handleStream probe didn't run. Try starting a new span here |
There was a problem hiding this comment.
Suggested change
| // if grpcReq_event is null, then handleStream probe didn't run. Try starting a new span here | |
| // if we fail to get an active grpc span, nothing to do here |
| bpf_probe_read_user(&s_ptr, sizeof(s_ptr), (void *)(status_ptr + status_s_pos)); | ||
| // Get status code from Status.s pointer | ||
| bpf_probe_read_user(&grpcReq_event_ptr->status_code, sizeof(grpcReq_event_ptr->status_code), (void *)(s_ptr + status_code_pos)); | ||
| bpf_map_update_elem(&grpc_events, &key, grpcReq_event_ptr, 0); |
There was a problem hiding this comment.
nit: I think this update call is redundant since we have a pointer to the map element and we are updating the underlying memory, but worth making sure.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref #172