Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add @grcevski as a Project Approver 🎉 #1082

Merged
merged 1 commit into from
Sep 11, 2024
Merged

Add @grcevski as a Project Approver 🎉 #1082

merged 1 commit into from
Sep 11, 2024

Conversation

MrAlias
Copy link
Contributor

@MrAlias MrAlias commented Sep 11, 2024 •
edited
Loading

Requirements

  • >=10 substantive contributions
  • Active > 1 month
  • Add to CONTRIBUTING.md (done in this PR)
  • Maintainer nomination: @MrAlias
  • Other maintainer(s) (@edeNFed @RonFed @damemi) sign-off
  • Add to @open-telemetry/go-instrumentation-approvers (post merge task)

@MrAlias MrAlias requested a review from a team September 11, 2024 17:41
@MrAlias
Copy link
Contributor Author

MrAlias commented Sep 11, 2024

Welcome @grcevski, and thank you for all the hard work. Please be sure to approve this to show your official acceptance of the role.

grcevski
grcevski approved these changes Sep 11, 2024
View reviewed changes
Copy link
Contributor

@grcevski grcevski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you @MrAlias!

@MrAlias MrAlias merged commit a03d514 into open-telemetry:main Sep 11, 2024
25 checks passed
@MrAlias MrAlias deleted the add-grcevski-approver branch September 11, 2024 20:13
MrAlias added a commit to MrAlias/opentelemetry-go-instrumentation that referenced this pull request Sep 18, 2024
@MrAlias
Add @grcevski as a project approver (open-telemetry#1082)
835988b
@MrAlias MrAlias added this to the v0.15.0-alpha milestone Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RonFed RonFed RonFed approved these changes

@grcevski grcevski grcevski approved these changes

@edeNFed edeNFed edeNFed approved these changes

@pellared pellared pellared approved these changes

@damemi damemi damemi approved these changes

Assignees
No one assigned
Labels
Skip Changelog
Projects
None yet
Milestone
v0.15.0-alpha
Development

Successfully merging this pull request may close these issues.
6 participants
@MrAlias @damemi @pellared @edeNFed @grcevski @RonFed