Add initial implementation of the zpages for Otel Trace #894
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bogdandrutu
requested review from
Aneurysm9,
dashpole,
evantorrie,
jmacd,
MadVikingGod,
MrAlias,
paivagustavo,
pellared and
XSAM
as code owners
bogdandrutu
force-pushed
the
zpages
branch
2 times, most recently
from
861c767 to
5afe70e
Compare
Aneurysm9
reviewed
Jul 19, 2021
Aneurysm9
approved these changes
Jul 19, 2021
MrAlias
approved these changes
Jul 20, 2021
bogdandrutu
force-pushed
the
zpages
branch
3 times, most recently
from
11c90ac to
fcc8a07
Compare
Codecov Report
@@ Coverage Diff @@
## main #894 +/- ##
=======================================
- Coverage 79.1% 75.3% -3.8%
=======================================
Files 62 68 +6
Lines 2748 3054 +306
=======================================
+ Hits 2174 2301 +127
- Misses 443 613 +170
- Partials 131 140 +9
|
MrAlias
approved these changes
Jul 20, 2021
|
@MadVikingGod are you around to take another look? |
|
Looks like |
Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
|
@MrAlias done |
14 tasks
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Code inspired mostly from https://github.com/census-instrumentation/opencensus-go/tree/v0.23.0/zpages
Signed-off-by: Bogdan Drutu bogdandrutu@gmail.com